fix: update stake image (#23324) #23330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## **Description** Updates the stake announcement image to a more up-to-date version to match the actual row. ## **Manual testing steps** 1. Install MM build with this change 2. The Stake announcement should appear, either last on the "What's New" list if you haven't seen previous announcements or as the only item in "What's New" if you have 3. The stake announcement should use the updated image ## **Screenshots/Recordings** ### **Before** Stake announcement preview image uses outdated design: <img width="314" alt="Screenshot 2024-03-05 at 12 05 41 PM" src="https://github.com/MetaMask/metamask-extension/assets/15035587/6608e5c7-f15e-44d5-8209-f398a35eae6f"> ### **After** Stake announcement preview image matches actual asset list item: <img width="322" alt="Screenshot 2024-03-05 at 3 17 59 PM" src="https://github.com/MetaMask/metamask-extension/assets/15035587/0d44ec7d-46b6-42e4-83c6-89bdbf4c9594"> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've clearly explained what problem this PR is solving and how it is solved. - [X] I've linked related issues - [X] I've included manual testing steps - [X] I've included screenshots/recordings if applicable - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [X] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
bergeron
approved these changes
Mar 5, 2024
Builds ready [8df9e0b]
Page Load Metrics (1849 ± 68 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks stake image commit in v11.11.2
Original PR into
develop: #23324