-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Migrate users that currently have opensea enabled to have blockaid enabled #23460
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
af7bd92
to
da97e45
Compare
Builds ready [94a52a8]
Page Load Metrics (1176 ± 521 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on the description, should we transfer the true states from transactionSecurityCheckEnabled
to securityAlertsEnabled
?
Builds ready [b2e6911]
Page Load Metrics (452 ± 359 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
6183c97
to
b68ebc1
Compare
b42b0ea
to
cd5fb73
Compare
@blackdevelopa made one comment, the rest LGTM! |
c049e59
to
b4dcef2
Compare
Builds ready [82517a0]
Page Load Metrics (719 ± 466 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23460 +/- ##
===========================================
+ Coverage 68.54% 68.59% +0.06%
===========================================
Files 1163 1163
Lines 44170 44104 -66
Branches 11816 11803 -13
===========================================
- Hits 30272 30252 -20
+ Misses 13898 13852 -46 ☔ View full report in Codecov by Sentry. |
There is also code related to displaying validation result on transaction pages that we would need to cleanup, but may be in separate PR. |
Missing release label release-11.14.0 on PR. Adding release label release-11.14.0 on PR and removing other release labels(release-11.14.1), as PR was added to branch 11.14.0 when release was cut. |
Description
With Blockaid successfully rolled to users by default and across multiple networks, we will be deprecating the earlier Opensea security alert feature and migrating users to Blockaid.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2133
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-03-20.at.12.20.59.mov
After
Screen.Recording.2024-03-20.at.12.19.25.mov
Pre-merge author checklist
Pre-merge reviewer checklist