fix: Fix confirmation tx totals on layer 2 networks and for erc20 transfers #23511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing #23510, I discovered that total fees had some inaccuracies in two cases:
The fix for 1 was to bring in fetching of layer1 multi-network fee data into the confirmation-transaction-base component.
The fix for 2 is just to make sure that when we are rendering the transaction detail line where
useMax
is false, we choose the correct token fee to render (see the newprimaryFee
variable introduced in this PR).These two fixes are included in separate commits
Before: Layer 2 total fees
After: Layer 2 total fees
Before: ERC20 sends
After: ERC20 sends
Pre-merge author checklist
Pre-merge reviewer checklist