You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is aiming to implement OptimismLayer1GasFeeFlow as a first use of transactionMeta.layer1GasFee. Hence it contains removal of fetchEstimatedL1Fee function and it's helper functions.
New transaction-controller version also includes a getLayer1GasFee function which could be used to obtain layer1GasFeeValue for un-existing transactions. This is being used in swaps controller.
This PR should not affect existing gas component that shows Layer1GasFee amount which appear on send flow, confirmation page & swaps. Hence manually testing any transaction on Optimism will work fine.
I've clearly explained what problem this PR is solving and how it is solved.
I've linked related issues
I've included manual testing steps
[] I've included screenshots/recordings if applicable
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
I’ve properly set the pull request status:
In case it's not yet "ready for review", I've set it to "draft".
In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is aiming to implement
OptimismLayer1GasFeeFlow
as a first use oftransactionMeta.layer1GasFee
. Hence it contains removal offetchEstimatedL1Fee
function and it's helper functions.New
transaction-controller
version also includes agetLayer1GasFee
function which could be used to obtainlayer1GasFeeValue
for un-existing transactions. This is being used in swaps controller.Optimism Layer 1 Gas Fee Flow PR in core: MetaMask/core#4055
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1945
Manual testing steps
This PR should not affect existing gas component that shows
Layer1GasFee
amount which appear on send flow, confirmation page & swaps. Hence manually testing any transaction onOptimism
will work fine.Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist