Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add scenario deploy contract, deposit and withdraw #23536

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

sleepytanya
Copy link
Contributor

@sleepytanya sleepytanya commented Mar 16, 2024

Description

In this PR we add the scenario for the flow 'Deploy contract, deposit and withdraw'.
This task belongs to the effort of documenting manual QA flows in this Epic.

Open in GitHub Codespaces

Related issues

Fixes: 22018

Manual testing steps

  1. Verify that the test steps align with the sequence in the video.
  2. You can find rendered table here.

Screenshots/Recordings

123.mov

Before

N/A

After

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sleepytanya sleepytanya added team-confirmations-system DEPRECATED: please use "team-confirmations" label instead release-11.4.0 Issue or pull request that will be included in release 11.4.0 labels Mar 16, 2024
@sleepytanya sleepytanya self-assigned this Mar 16, 2024
@sleepytanya sleepytanya requested a review from a team as a code owner March 16, 2024 04:55
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sleepytanya sleepytanya requested a review from segun March 16, 2024 05:02
@metamaskbot
Copy link
Collaborator

Builds ready [03029e2]
Page Load Metrics (1383 ± 556 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint9379018314570
domContentLoaded16334636632
load88319613831159556
domInteractive16334636632
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.45%. Comparing base (59e9948) to head (d157f4b).

❗ Current head d157f4b differs from pull request most recent head fa084ac. Consider uploading reports for the commit fa084ac to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23536      +/-   ##
===========================================
- Coverage    68.45%   68.45%   -0.01%     
===========================================
  Files         1142     1141       -1     
  Lines        43773    43769       -4     
  Branches     11719    11729      +10     
===========================================
- Hits         29964    29958       -6     
- Misses       13809    13811       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [d157f4b]
Page Load Metrics (1042 ± 373 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint641731263014
domContentLoaded1089332412
load5818961042776373
domInteractive1089332412
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@hjetpoluru
Copy link
Contributor

@sleepytanya, could you attach the video.

Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sleepytanya sleepytanya merged commit d0d23f7 into develop Mar 19, 2024
64 of 66 checks passed
@sleepytanya sleepytanya deleted the deploy-deposit-withdraw branch March 19, 2024 14:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
@metamaskbot metamaskbot added release-11.14.0 Issue or pull request that will be included in release 11.14.0 and removed release-11.14.0 Issue or pull request that will be included in release 11.14.0 labels Mar 19, 2024
@metamaskbot
Copy link
Collaborator

More than one release label on PR. Keeping the lowest one (release-11.4.0) on PR and removing other release labels (release-11.14.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.4.0 Issue or pull request that will be included in release 11.4.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Deploy contracts, deposit and withdraw
5 participants