-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Release Transaction Insights V2 & Signature Insights to stable #23630
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hmalik88 The signature insight permission needs to be unfenced and removed from excluded permissions too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please enable the E2Es in stable as well:
https://github.com/MetaMask/metamask-extension/blob/develop/test/e2e/run-all.js#L12
https://github.com/MetaMask/metamask-extension/blob/develop/test/e2e/run-all.js#L14
Builds ready [42d2931]
Page Load Metrics (682 ± 497 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23630 +/- ##
========================================
Coverage 67.54% 67.55%
========================================
Files 1245 1245
Lines 48866 48861 -5
Branches 12744 12743 -1
========================================
- Hits 33005 33004 -1
+ Misses 15861 15857 -4 ☔ View full report in Codecov by Sentry. |
Builds ready [e8ddef0]
Page Load Metrics (1055 ± 512 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [ae8ec04]
Page Load Metrics (1394 ± 568 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the changes in part of code owned by confirmations team ui/pages/confirmations/..
, those look good 👍
Transaction insight logic was refactored and fencing for both transaction and signature insights was
updatedremoved to bring the features into stable.