Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Release Transaction Insights V2 & Signature Insights to stable #23630

Merged
merged 25 commits into from
Apr 15, 2024

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Mar 21, 2024

Transaction insight logic was refactored and fencing for both transaction and signature insights was updated removed to bring the features into stable.

@hmalik88 hmalik88 added the team-snaps-platform Snaps Platform team label Mar 21, 2024
@hmalik88 hmalik88 requested review from a team as code owners March 21, 2024 15:10
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 21, 2024
@hmalik88 hmalik88 removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 21, 2024
Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmalik88 The signature insight permission needs to be unfenced and removed from excluded permissions too

@hmalik88 hmalik88 requested review from a team as code owners April 8, 2024 09:57
Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 11, 2024
@hmalik88 hmalik88 changed the title Release Transaction Insights V2 & Signature Insights to stable feat: Release Transaction Insights V2 & Signature Insights to stable Apr 11, 2024
@hmalik88 hmalik88 removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 11, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 11, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [42d2931]
Page Load Metrics (682 ± 497 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint751741122713
domContentLoaded115125105
load5427056821035497
domInteractive115125105
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 10.1 KiB (0.16%)
  • common: -32 Bytes (-0.00%)

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.55%. Comparing base (1098a10) to head (ae8ec04).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23630   +/-   ##
========================================
  Coverage    67.54%   67.55%           
========================================
  Files         1245     1245           
  Lines        48866    48861    -5     
  Branches     12744    12743    -1     
========================================
- Hits         33005    33004    -1     
+ Misses       15861    15857    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Mrtenz
Mrtenz previously approved these changes Apr 12, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [e8ddef0]
Page Load Metrics (1055 ± 512 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint723391467235
domContentLoaded1192312010
load59246010551067512
domInteractive1192312010
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 10.14 KiB (0.16%)
  • common: -32 Bytes (-0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ae8ec04]
Page Load Metrics (1394 ± 568 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint834251568842
domContentLoaded118627157
load69270313941184568
domInteractive118627157
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 10.65 KiB (0.17%)
  • common: -32 Bytes (-0.00%)

Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes in part of code owned by confirmations team ui/pages/confirmations/.., those look good 👍

@hmalik88 hmalik88 merged commit 96d478a into develop Apr 15, 2024
67 of 68 checks passed
@hmalik88 hmalik88 deleted the hm/insights-stable-release branch April 15, 2024 11:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants