Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): update amannn/action-semantic-pull-request to v5.4.0 #23819

Merged

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Apr 1, 2024

Update amannn/action-semantic-pull-request@v5.2.0 to v5.4.0 as v5.2.0 is deprecated.

Copy link
Contributor

github-actions bot commented Apr 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@davidmurdoch davidmurdoch changed the title ci: update amannn/action-semantic-pull-request to v5.4.0 ci: update amannn/action-semantic-pull-request to v5.4.0 Apr 1, 2024
@davidmurdoch davidmurdoch marked this pull request as ready for review April 1, 2024 18:35
@davidmurdoch davidmurdoch requested a review from a team as a code owner April 1, 2024 18:35
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.59%. Comparing base (e322bc8) to head (d4cd303).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23819   +/-   ##
========================================
  Coverage    67.59%   67.59%           
========================================
  Files         1247     1247           
  Lines        48925    48925           
  Branches     12766    12766           
========================================
  Hits         33067    33067           
  Misses       15858    15858           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [1cca10e]
Page Load Metrics (373 ± 335 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint601551012512
domContentLoaded95123115
load482051373698335
domInteractive95123115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidmurdoch
Copy link
Contributor Author

This workflow is not on the allowlist: https://github.com/MetaMask/metamask-extension/actions/runs/8512078157

Where does this allow list live?

@metamaskbot
Copy link
Collaborator

Builds ready [51606f5]
Page Load Metrics (1059 ± 593 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint723771358240
domContentLoaded14422384
load60324510591234593
domInteractive14422384
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [175c5ce]
Page Load Metrics (1418 ± 646 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint743741548541
domContentLoaded10109312813
load55339014181346646
domInteractive10109312813
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@davidmurdoch davidmurdoch changed the title ci: update amannn/action-semantic-pull-request to v5.4.0 ci(actions): update amannn/action-semantic-pull-request to v5.4.0 Apr 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [d4cd303]
Page Load Metrics (1027 ± 625 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint653711379747
domContentLoaded96025136
load53320810271301625
domInteractive96025136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@davidmurdoch davidmurdoch merged commit 670f2e1 into develop Apr 16, 2024
70 of 71 checks passed
@davidmurdoch davidmurdoch deleted the update-amannn-action-semantic-pull-request-action branch April 16, 2024 21:11
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants