build: remove brfs from build processes

[davidmurdoch]

The brfs package was used to transform calls to fs.readFile* into inlined files as strings during build/compilation. We no longer make use of fs.readFile* in our code, so the dependency is no longer required. While it doesn't cause issues to leave it, the package is slow as it must parse the contents into an AST and then statically analyze the tree looking for relevant calls to fs.readFile*. This overhead is unwanted, so I've removed it from our build process.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/merge-source-map@1.1.0	None	0	6.58 kB	keik

🚮 Removed packages: npm/array-from@2.1.1, npm/brfs@2.0.2, npm/buffer-equal@0.0.1, npm/dash-ast@2.0.1, npm/es6-map@0.1.5, npm/es6-set@0.1.6, npm/estree-is-function@1.0.0, npm/merge-source-map@1.0.4, npm/quote-stream@1.0.2, npm/scope-analyzer@2.1.2, npm/shallow-copy@0.0.1, npm/static-eval@2.1.1, npm/static-module@3.0.4

View full report↗︎

[metamaskbot]

Builds ready [e0fb026]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1244 ± 571 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	382	138	74	35
		domContentLoaded	11	126	33	30	14
		load	55	2962	1244	1190	571
		domInteractive	11	126	33	30	14

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 19 Bytes (0.00%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.54%. Comparing base (1098a10) to head (e0fb026).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #24000   +/-   ##
========================================
  Coverage    67.54%   67.54%           
========================================
  Files         1245     1245           
  Lines        48866    48866           
  Branches     12744    12744           
========================================
  Hits         33005    33005           
  Misses       15861    15861           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.