Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checkmark icon missing after token import #24005

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Apr 12, 2024

Description

After importing an erc20 token, the popup message was not rendering the checkmark icon.

The icon is from font-awesome, and their CSS works fine. But when we add @include design-system.H3, it overrode the font-family, breaking the icon.

Fixed by setting font size directly rather than bringing the whole H3.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. Import an erc20 token, either manually or via autodetection
  2. Verify the green popup message has a checkmark icon

Screenshots/Recordings

Before

Screenshot 2024-04-12 at 10 58 57 AM

After

Screenshot 2024-04-12 at 12 00 30 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner April 12, 2024 19:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Apr 12, 2024
@bergeron bergeron changed the title fix checkmark icon missing after token import fix: checkmark icon missing after token import Apr 12, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [53a3e10]
Page Load Metrics (1510 ± 626 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint803551506632
domContentLoaded117828178
load63313715101303626
domInteractive117828178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (fef29be) to head (53a3e10).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24005   +/-   ##
========================================
  Coverage    67.56%   67.56%           
========================================
  Files         1246     1246           
  Lines        48888    48888           
  Branches     12746    12746           
========================================
  Hits         33031    33031           
  Misses       15857    15857           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bergeron bergeron merged commit 4dc299e into develop Apr 15, 2024
79 of 85 checks passed
@bergeron bergeron deleted the brian/fix-checkmark-after-token-import branch April 15, 2024 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants