-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve blockaid error/warning copy #24037
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -33,7 +33,7 @@ const REASON_TO_DESCRIPTION_TKEY = Object.freeze({ | |||
|
|||
[BlockaidReason.blurFarming]: 'blockaidDescriptionBlurFarming', | |||
|
|||
[BlockaidReason.errored]: 'blockaidDescriptionErrored', // TODO: change in i8n | |||
[BlockaidReason.errored]: 'blockaidDescriptionErrored', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep above comment, the issue I think is when i18n message keys should not be used like above. That makes it hard for i18n tool to discover un-used keys etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay sure. I wasn't sure why the comment was there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except a small comment added.
1bb685c
to
c06b5d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24037 +/- ##
========================================
Coverage 67.58% 67.58%
========================================
Files 1247 1247
Lines 48934 48934
Branches 12774 12774
========================================
Hits 33069 33069
Misses 15865 15865 ☔ View full report in Codecov by Sentry. |
Builds ready [32ff830]
Page Load Metrics (1515 ± 684 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [36e6a93]
Page Load Metrics (2039 ± 618 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
We should update content for:
when ppom returns warning as response
Related issues
Fixes: #1758
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist