Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump phishing-controller to ^9.0.2 #24311

Merged
merged 7 commits into from
May 1, 2024

Conversation

kanthesha
Copy link
Contributor

@kanthesha kanthesha commented Apr 30, 2024

Description

This version of phishing-controller includes the changes to Stalelist update interval to 30 days and the hotlist update interval to 5 mins.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Apr 30, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 30, 2024
@kanthesha
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Gudahtt
Copy link
Member

Gudahtt commented Apr 30, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot
Copy link
Collaborator

Builds ready [9d82c74]
Page Load Metrics (182 ± 258 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5912474178
domContentLoaded8451394
load472522182537258
domInteractive8451394
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -5.7 KiB (-0.15%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (d15626b) to head (9d82c74).

❗ Current head 9d82c74 differs from pull request most recent head 17c2e3e. Consider uploading reports for the commit 17c2e3e to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24311   +/-   ##
========================================
  Coverage    67.28%   67.28%           
========================================
  Files         1275     1275           
  Lines        49707    49707           
  Branches     12916    12916           
========================================
  Hits         33444    33444           
  Misses       16263    16263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gudahtt Gudahtt force-pushed the bump-phishing-controller-version branch from 9d82c74 to 17c2e3e Compare April 30, 2024 21:19
@Gudahtt Gudahtt marked this pull request as ready for review April 30, 2024 21:19
@Gudahtt Gudahtt requested review from a team as code owners April 30, 2024 21:19
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kanthesha kanthesha merged commit 2c45770 into develop May 1, 2024
70 of 71 checks passed
@kanthesha kanthesha deleted the bump-phishing-controller-version branch May 1, 2024 13:25
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
@metamaskbot metamaskbot added the release-11.17.0 Issue or pull request that will be included in release 11.17.0 label May 1, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [4966a4b]
Page Load Metrics (820 ± 633 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5913084199
domContentLoaded9361473
load4736028201318633
domInteractive9361473
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -5.7 KiB (-0.15%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.17.0 Issue or pull request that will be included in release 11.17.0 team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants