Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v11.15.3 #24395

Merged
merged 5 commits into from
May 7, 2024
Merged

Version v11.15.3 #24395

merged 5 commits into from
May 7, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented May 6, 2024

No description provided.

Copy link
Contributor

github-actions bot commented May 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm changed the base branch from develop to master May 6, 2024 23:33
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 6, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [c9acdd3]
Page Load Metrics (1690 ± 705 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint792151264019
domContentLoaded13482474
load67380316901469705
domInteractive13482474

@metamaskbot metamaskbot added the release-11.15.3 Issue or pull request that will be included in release 11.15.3 label May 7, 2024
dbrans and others added 2 commits May 7, 2024 06:26
Cherry-pick f77eac5 (#24394) into
v11.15.3

Co-authored-by: Daniel <80175477+dan437@users.noreply.github.com>
…#24389) into v11.15.3 (#24397)

Cherry-pick f0ac9c0, (#24389) into
v11.15.3

Co-authored-by: Daniel <80175477+dan437@users.noreply.github.com>
…24408)

## **Description**

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24408?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Copy link

socket-security bot commented May 7, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/smart-transactions-controller@10.0.0 network +8 2.61 MB mcmire

🚮 Removed packages: npm/@metamask/smart-transactions-controller@8.1.0

View full report↗︎

Copy link

socket-security bot commented May 7, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/smart-transactions-controller@10.0.0, npm/metamask-crx@11.15.3

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@danjm
Copy link
Contributor Author

danjm commented May 7, 2024

@SocketSecurity ignore-all

@metamaskbot
Copy link
Collaborator

Builds ready [dea4bc0]
Page Load Metrics (692 ± 517 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint651441002211
domContentLoaded96425168
load5229176921077517
domInteractive96425168

@danjm
Copy link
Contributor Author

danjm commented May 7, 2024

@dan437 and @davibroc did some testing and it passed.

@danjm danjm marked this pull request as ready for review May 7, 2024 21:02
@danjm danjm requested review from a team as code owners May 7, 2024 21:02
@danjm danjm merged commit fbd28c8 into master May 7, 2024
71 of 72 checks passed
@danjm danjm deleted the Version-v11.15.3 branch May 7, 2024 21:03
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.15.3 Issue or pull request that will be included in release 11.15.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants