-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable signatures redesign new users #24466
feat: enable signatures redesign new users #24466
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
||
if (process.env.ENABLE_CONFIRMATION_REDESIGN) { | ||
SETTINGS_CONSTANTS.push({ | ||
{ | ||
tabMessage: (t) => t('experimental'), | ||
sectionMessage: (t) => t('redesignedConfirmationsEnabledToggle'), | ||
descriptionMessage: (t) => t('redesignedConfirmationsToggleDescription'), | ||
route: `${EXPERIMENTAL_ROUTE}#redesigned-confirmations`, | ||
icon: 'fas fa-flask', | ||
}); | ||
} | ||
}, | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[in and partially out of scope]
would be nice to move these above the snaps experimental settings. We should update the references as well. Looks like the snaps one has gotten out of order. With this change, we should have
// experimental settingsRefs[0]
{
tabMessage: (t) => t('experimental'),
sectionMessage: (t) => t('petnamesEnabledToggle'),
descriptionMessage: (t) => t('petnamesEnabledToggleDescription'),
route: `${EXPERIMENTAL_ROUTE}#nicknames`,
icon: 'fas fa-flask',
},
// experimental settingsRefs[1]
{
tabMessage: (t) => t('experimental'),
sectionMessage: (t) => t('notificationsFeatureToggle'),
descriptionMessage: (t) => t('notificationsFeatureToggleDescription'),
route: `${EXPERIMENTAL_ROUTE}#notifications`,
icon: 'fas fa-flask',
},
// experimental settingsRefs[2]
{
tabMessage: (t) => t('experimental'),
sectionMessage: (t) => t('redesignedConfirmationsEnabledToggle'),
descriptionMessage: (t) => t('redesignedConfirmationsToggleDescription'),
route: `${EXPERIMENTAL_ROUTE}#redesigned-confirmations`,
icon: 'fas fa-flask',
},
///: BEGIN:ONLY_INCLUDE_IF(keyring-snaps)
// since this route is only included with keyring-snaps feature flag, this needs to be the last settingsRef for the experimental tab
// experimental settingsRefs[3]
{
tabMessage: (t) => t('experimental'),
sectionMessage: (t) => t('snaps'),
descriptionMessage: (t) => t('addSnapAccountToggle'),
route: `${EXPERIMENTAL_ROUTE}#snaps`,
icon: 'fas fa-flask',
},
then the refs in ui/pages/settings/experimental-tab/experimental-tab.component.js
should be updated appropriately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! minor comment above that can be handled in a separate PR
https://github.com/MetaMask/metamask-extension/pull/24466/files#r1595902839
728b1d4
We are moving the toggle from within the redesign env var, as from now on all users will be able to see the new redesign toggle under experimental settings
Personal sign and typed sign confirmations are no longer under the redesign env var. From this commit onwards, if a user has the preferences toggle on, he will be routed through the new redesign signature pages.
By default, new users will have the redesign toggle enabled
redesign env is not required to be set up for signatures e2e or unit tests
728b1d4
to
1108bf5
Compare
1108bf5
to
689d58a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24466 +/- ##
========================================
Coverage 67.43% 67.43%
========================================
Files 1286 1286
Lines 50105 50101 -4
Branches 12995 12991 -4
========================================
- Hits 33787 33785 -2
+ Misses 16318 16316 -2 ☔ View full report in Codecov by Sentry. |
Builds ready [689d58a]
Page Load Metrics (793 ± 539 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut. |
Description
🎉 Initial release for signatures redesign 🎉
Users will be able to toggle into the new confirmation pages for personal and typed data signatures. New users will have it enabled by default.
Related issues
Fixes: #24312
Manual testing steps
[Existing user:]
Improved signature requests
[New installation]
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist