Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @metamask/transaction-controller@^29.1.0->^30.0.0 #24861

Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 29, 2024

Description

Updates @metamask/transaction-controller and @metamask/network-controller to use latest version of @metamask/eth-block-tracker containing fix for multiple polling loops.
Updates @metamask/network-controller for the same and ensuring block tracker is in sync.

The nonce-tracker patch is removed as the changes have been incorporated in the new version, which is now used consistently.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat changed the title deps: @metamask/transaction-controller@^29.1.0->^30.0.0 fix: @metamask/transaction-controller@^29.1.0->^30.0.0 May 29, 2024
@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels May 29, 2024
@legobeat legobeat requested a review from dbrans May 29, 2024 12:12
@legobeat legobeat marked this pull request as ready for review May 29, 2024 12:13
@legobeat legobeat requested review from a team as code owners May 29, 2024 12:13
@legobeat legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch from a885388 to 4da3ec0 Compare May 29, 2024 12:19
Copy link

socket-security bot commented May 29, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/network-controller@18.1.2 environment +6 792 kB metamaskbot
npm/@metamask/nonce-tracker@5.0.0 None +1 64.5 kB
npm/@metamask/transaction-controller@30.0.0 None +1 129 kB

🚮 Removed packages: npm/@metamask/network-controller@18.1.0

View full report↗︎

@legobeat legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch 2 times, most recently from dff2780 to cf6187c Compare May 29, 2024 13:56
@legobeat legobeat requested review from naugtur and mcmire May 29, 2024 13:58
@legobeat legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch 3 times, most recently from 7b44c5a to 36b6c33 Compare May 29, 2024 16:25
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.71%. Comparing base (63851c9) to head (d06eb7c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24861      +/-   ##
===========================================
- Coverage    65.71%   65.71%   -0.00%     
===========================================
  Files         1368     1368              
  Lines        54388    54388              
  Branches     14150    14150              
===========================================
- Hits         35739    35737       -2     
- Misses       18649    18651       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch 9 times, most recently from d288c19 to 6bb8cee Compare May 29, 2024 23:26
zone-live
zone-live previously approved these changes Jun 3, 2024
@legobeat legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch from 11f7e1e to 3bd7d28 Compare June 3, 2024 15:58
@legobeat legobeat dismissed stale reviews from zone-live and dbrans via af52b59 June 3, 2024 16:27
@legobeat legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch from 3bd7d28 to af52b59 Compare June 3, 2024 16:27
@legobeat legobeat requested review from zone-live and dbrans June 3, 2024 16:32
@legobeat legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch from af52b59 to 2f69af1 Compare June 3, 2024 16:35
@legobeat legobeat requested a review from a team June 3, 2024 16:36
@legobeat legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch 5 times, most recently from 0121814 to d08b0da Compare June 3, 2024 18:42
@legobeat legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch from d08b0da to dc00895 Compare June 3, 2024 20:50
@legobeat legobeat requested a review from a team June 3, 2024 21:21
@legobeat legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch 2 times, most recently from 3a96372 to ec1178f Compare June 4, 2024 02:42
@legobeat legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch from ec1178f to d06eb7c Compare June 4, 2024 02:59
@legobeat legobeat merged commit 04c2e90 into MetaMask:develop Jun 4, 2024
77 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
@legobeat legobeat deleted the fix-block-tracker-multiple-polling-loops branch June 4, 2024 04:17
@benjisclowder benjisclowder added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-security
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants