Conversion implementation #520
Conversation
|
Make sure you merge master into your long-running branch periodically so it doesn't diverge too far! |
2-am-zzz
force-pushed
the
usd-conversion
branch
from
67f1a4b
to
7725f38
Compare
|
|
|
This PR is finished! Waiting for additional comments or a merge @FlySwatter @kumavis @frankiebee |
|
@Zanibas is the NaN issue resolved? (see tx history in screenshots ) |
|
I don't think you need an I would also add the currency suffix to the accounts page, and remove the equal sign there too. |
|
@FlySwatter it was suggested in Vlad's design: is it no good? |
|
@Zanibas I don't really like it, maybe use parens instead |
|
I don't think equals or parens are needed. Different font color + currency suffix will make it very obvious. |
| EthBalanceComponent.prototype.renderBalance = function (value, state) { | ||
| console.log("THIS IS VALUE") | ||
| console.log(value) | ||
| console.log(state.conversionRate) |
|
Tests are failing. probably linter issues. This PR looks good! Great work, @Zanibas, this was a large feature, and you've done it very cleanly, nice tests, good use of our state tree, metamask controller, config manager, very solid contribution! |
|
Removed the equal sign, but now to account for failing APIs, we just hide that part of the UI (no conversion is shown at all). Showing a message indicating unavailable conversions was pretty ugly--we can revisit this if this is undesired. |
|
I like the solution of hiding the value when it's unavailable. |
Work in Progress. Fixes #278, Fixes #461, Fixes #362. Pulling a PR here for accountability and team checks.
Essentially does these things (or hopes to do so):
Uses the Cryptonator API to pull data occasionally on some fiat currency to ether conversion. Thankfully they don't have limits, so we can ping liberally.
Allows users to select from a currently pre-defined list of fiat currencies from the config menu.
Shows users the equivalent fiat value when hovering over any ether value.