Add custom hd path option #9367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
|
I'm super stoked and excited about this PR, adding a long-requested feature from the community. 👏 👏 👏 Thanks @PatrykLucka! |
PatrykLucka
force-pushed
the
add-custom-hd-path-option
branch
from
e7c5409
to
cdf171b
Compare
PatrykLucka
force-pushed
the
add-custom-hd-path-option
branch
from
cdf171b
to
604e314
Compare
rekmarks
approved these changes
Nov 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding accounts from a Ledger wallet, there are 2 options for the HD path,
This PR adds an option to specify custom HD path.
Fixes #6716
Fixes #7486
Fixes #7238