Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not publish swaps transaction if the estimateGas call made when adding the tx fails. #9947

Merged
merged 1 commit into from Jan 22, 2021

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Nov 26, 2020

This PR is explained by the inline comment that is added within the code change.

For now, the swaps that are failed due to the changes in this PR will have the same error screen as all other failures. That will be improved upon with #9948

@danjm danjm requested a review from a team as a code owner November 26, 2020 10:16
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [29e5374]
Page Load Metrics (494 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3293622211
domContentLoaded3205644927737
load3225664947737
domInteractive3205644927737

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 7f1f683 into develop Jan 22, 2021
@Gudahtt Gudahtt deleted the fail-swap-if-simulation-fails branch January 22, 2021 21:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants