Skip to content

Commit

Permalink
fix: deeplink invalid error when importing privateKey via qr (#9569)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
A fix for this issue:
#9517
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
omridan159 authored and Andepande committed May 21, 2024
1 parent 44b1a4a commit 975ef0e
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions app/core/DeeplinkManager/ParseManager/parseDeeplink.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,13 @@ function parseDeeplink({

return true;
} catch (error) {
Logger.error(
error as Error,
'DeepLinkManager:parse error parsing deeplink',
);
const isPrivateKey = url.length === 64;
if (error && !isPrivateKey) {
Logger.error(
error as Error,
'DeepLinkManager:parse error parsing deeplink',
);

if (error) {
Alert.alert(strings('deeplink.invalid'), `Invalid URL: ${url}`);
}

Expand Down

0 comments on commit 975ef0e

Please sign in to comment.