Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Invalid deeplink error when importing a private key by QR #9517

Closed
plasmacorral opened this issue May 2, 2024 · 1 comment
Closed

[Bug]: Invalid deeplink error when importing a private key by QR #9517

plasmacorral opened this issue May 2, 2024 · 1 comment
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.22.0 release-7.22.0 Issue or pull request that will be included in release 7.22.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-sdk SDK team type-bug Something isn't working

Comments

@plasmacorral
Copy link
Contributor

plasmacorral commented May 2, 2024 •
edited

Describe the bug

When importing a valid private key by QR code, user is shown an error: "Invalid deeplink Invalid URL:" and the private key string is displayed in the error message. The account is successfully imported, but the error message is not appropriate in this scenario.

Was observed with QA build from PR 9318/9508, with multiple devices:
Pixel 5a- Android 14
Samsung a515f- Android 12
iPhone Xs- iOS 17.4.1

Not present on 7.21.0, but can be reproduced on the RC build 1321 for 7.22.0 as well as Main

Expected behavior

Account is imported , user does not have to click OK on an error to proceed.

Screenshots/Recordings

Steps to reproduce

  1. Import an SRP and get to wallet view
  2. Follow add account flow for importing private key
  3. Scan QR of valid private key
  4. Observe error

Error messages or log output

No response

Version

7.22.0

Build type

None

Device

Several

Operating system

iOS, Android

Additional context

Account is imported successfully, even though inappropriate error is shown and includes private key as entered

Severity

No response
@plasmacorral plasmacorral added type-bug Something isn't working team-sdk SDK team Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.22.0 Issue or pull request that will be included in release 7.22.0 labels May 2, 2024
@plasmacorral plasmacorral mentioned this issue May 2, 2024
Merged
7 tasks
@omridan159 omridan159 mentioned this issue May 7, 2024
Merged
7 tasks
christopherferreira9 pushed a commit that referenced this issue May 9, 2024
@omridan159
fix: deeplink invalid error when importing privateKey via qr (#9569)
a8d30c7 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
A fix for this issue:
#9517
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@christopherferreira9
Copy link
Contributor

Closing this as it was fixed in https://app.zenhub.com/workspaces/mobile-release-testing-6249e5242464b70013315a98/issues/gh/metamask/metamask-mobile/9569

Andepande pushed a commit that referenced this issue May 21, 2024
@omridan159 @Andepande
fix: deeplink invalid error when importing privateKey via qr (#9569)
975ef0e 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
A fix for this issue:
#9517
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.22.0 release-7.22.0 Issue or pull request that will be included in release 7.22.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-sdk SDK team type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@plasmacorral @metamaskbot @christopherferreira9