Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry: ApplicationNotResponding: Application Not Responding for at least 4000 ms. #2498

Closed
sentry-io bot opened this issue Apr 12, 2021 · 9 comments · Fixed by #2603
Closed

Sentry: ApplicationNotResponding: Application Not Responding for at least 4000 ms. #2498

sentry-io bot opened this issue Apr 12, 2021 · 9 comments · Fixed by #2603
Assignees
@sethkfman
Labels
type-bug Something isn't working
Milestone
Tooling Sprint

Comments

@sentry-io
Copy link

sentry-io bot commented Apr 12, 2021

Sentry Issue: METAMASK-MOBILE-BKK

ApplicationNotResponding: Application Not Responding for at least 4000 ms.
    at android.view.ThreadedRenderer.nDestroy(ThreadedRenderer.java)
    at android.view.ThreadedRenderer.destroy(ThreadedRenderer.java:411)
    at android.view.ViewRootImpl.destroyHardwareRenderer(ViewRootImpl.java:6529)
    at android.view.ViewRootImpl.dispatchDetachedFromWindow(ViewRootImpl.java:3554)
    at android.view.ViewRootImpl.doDie(ViewRootImpl.java:6459)
...
(14 additional frame(s) were not displayed)
@sentry-io
Copy link
Author

sentry-io bot commented Apr 12, 2021

Sentry issue: METAMASK-MOBILE-3D

@sentry-io
Copy link
Author

sentry-io bot commented Apr 13, 2021

Sentry issue: METAMASK-MOBILE-A8F

@sentry-io
Copy link
Author

sentry-io bot commented Apr 13, 2021

Sentry issue: METAMASK-MOBILE-1P

@sentry-io
Copy link
Author

sentry-io bot commented Apr 13, 2021

Sentry issue: METAMASK-MOBILE-53

@sentry-io
Copy link
Author

sentry-io bot commented Apr 13, 2021

Sentry issue: METAMASK-MOBILE-PN

@sentry-io
Copy link
Author

sentry-io bot commented Apr 13, 2021

Sentry issue: METAMASK-MOBILE-2X

@andrepimenta andrepimenta added this to the Tooling Sprint milestone Apr 13, 2021
@mobularay
Copy link
Contributor

How critical is this issue? How often is this happening? And are we seeing this issue being flagged at Customer support level? Just trying to determine priority, thanks so much! @sethkfman @andrepimenta

@sethkfman
Copy link
Contributor

There are a number of ANRs that are reported in Sentry well over 1000 over a 14 day period. This task was to take a look at these Android level crashes and see if there is a common thread for the issue and what solutions we may have at a native Android level. Sentry Link showing all ANRs in 14day period: https://sentry.io/organizations/metamask/issues/?environment=production&groupStatsPeriod=auto&project=2299799&query=ApplicationNotResponding&statsPeriod=14d
@andrepimenta @mobularay

@sethkfman
Copy link
Contributor

During the investigation it the ANRs are occurring during the SplashScreen/Login sequence. There are two activities that are occurring that this time that could be contributing to this issue: Fox loading animation & fetching the stored data. I have updated the Sentry SDK and increased the ANR timeout to help reduce this issue. I plan to looking the Sentry error to see if the rate has decreased since the release of the FileStorage mechanism.

sethkfman added a commit that referenced this issue Apr 26, 2021
@sethkfman
updated Sentry SDK and increase the default timeout for ANR to be thr…
08cc4f6 
…own from 4 to 10 seconds #2498
@sethkfman sethkfman mentioned this issue Apr 28, 2021
Merged
3 tasks
@mobularay mobularay added the type-bug Something isn't working label Apr 28, 2021
sethkfman added a commit that referenced this issue May 3, 2021
@sethkfman
Bugfix/android anr (#2603)
9361631 
* updated Sentry SDK and increase the default timeout for ANR to be thrown  from 4 to 10 seconds #2498

* updated ANR reporting time to 8 seconds

* removed increased timeout and correct sentry integrations vesion

* updated pod dependencies
sethkfman added a commit that referenced this issue May 12, 2021
@sethkfman @rickycodes
@Pixeladed @wachunei @estebanmino @Gudahtt @andrepimenta @ScreamingHawk @ibrahimtaveras00 @darkwing @dependabot
Release/v2.3.0 (#2677)
867369e 
* resolve isENS without case sensitivity (#2545) (#2568)

Co-authored-by: ricky <ricky.miller@gmail.com>

Co-authored-by: Minh <minhle@canva.com>

* Use node 14 (#2539)

* Swaps: BSC Support (#2468)

* Swaps: Add cache thresholds configuration (#2514)

* Upgrade .nvmrc to node v14 (#2588)

* Address yarn lints (#2524)

* address yarn lints

* add eslint-disable

* Update isENS method

* fix rn-fetch-blob.js mock

* Add tests for isENS

* useRef instead of useMemo

* Update eslint

* Use lastIndexOf and add test

* Add test case for ricky.metamask.eth

* Add offset

* Fix AppConstants import

* only add custom tokens if not in mainnet (#2470)

* checkchainid

* tests

* Fix adding custom token in custom network (#2590)

* Replace controller context (#2416)

* Replace controller context

The `context` object previously constructed by the
`ComposableController` is no more. Instead each controller now accepts
its dependencies directly as constructor parameters, in a similar
manner to the extension controllers.

This was done in preparation for migrating to BaseControllerV2 and the
new controller messaging system - this is just a temporary solution
that will let us migrate controllers one at a time.

The style of dependency injection here matches the extension (at least
with newer controllers anyway). Specific methods and state snapshots
are injected rather than entire controllers, to help simplify unit
tests and make it easier to understand how controllers interact.

The `Engine.context` property was used throughout mobile, so it has
been preserved. It is now constructed explicitly, rather than being a
re-export of the `ComposableController` context.

This PR depends upon MetaMask/core#387

* Pass in function for `getOpenSeaApiKey` rather than string

The API key was passed in directly by accident, instead of a function get returned the key. This has been fixed.

Co-authored-by: Esteban Miño <efmino@uc.cl>

* Update `AccountTrackerController` options

The `AccountTrackerController` option `initialIdentities` was replaced
with `getIdentities`. The initial identities passed in here were
incorrect anyway due to a typo (`initialState.preferencesController`
was used instead of `initialState.PreferencesController`).

* Fix `getIdentities` handler for `AccountTrackerController`

* Set initial controller state

The `controllers` setter on `ComposedController` used to be responsible
for setting initial state. Since that setter has been removed, the
initial state is now set after the controllers have been constructed.

This should be functionally equivalent to what it was before. We're
setting the initial state by calling `update` on each controller, just
as the `controller` setter used to.

* Fix initial state variable reference

Co-authored-by: Esteban Miño <efmino@uc.cl>

* fix typeface on login text field (#2610)

* Feature/confusables (#2464)

* Add confusable warning to SendTo

* Highlight confusable characters

* Replace zeroWidthPoints characters with ?

* Add some notes

* Add confusable highlight to confirm screen

* Update checkZeroWidth function

* Add exclamation mark to Confirm

* Add handleConfusables method

* Move this into one spot

* Add hasZeroWidthPoints

* Rename T to Texts

* Use reduce

* Add homoglyphic tests

* Add Modal for confusable on confirm screen

* Update snapshot

* Use Swaps InfoModal

* Increase lineheight on modals

* Only display warning if address is not in addressBook

* Update snapshot

* Make texts lowercase

* Remove unused state

* Add patch

* Display as warning in yelllow when not zero width

* Only display confusables warnings if the user is not in addressbook

* Add optional chaining for addressBook

Co-authored-by: andrepimenta <andrepimenta7@gmail.com>

* Add New Zealand Dollar to currency options (#2446)

* Add New Zealand Dollar to currency options

* Update snapshot to include nzd

Co-authored-by: Ricky Miller <ricky.miller@gmail.com>

* Move some errors to analytics instead of sentry (#2529)

* Move some errors to analytics instead of sentry

* Add swaps errors

* Change to log just as 1 error

* Fix typos

* Log can't reach branch servers as analytics

* Browser: Failed to resolve ENS name for chainId - log as analytics

* Update tests

Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>

* Don't hide url modal on emulator (#2604)

* Detox/Fix failing tests (#2607)

* fixed all failing tests

* remove a

Co-authored-by: Ibrahim Taveras <ibrahimtaveras@ibrahims-mbp.myfiosgateway.com>

* Upgrade wallet connect (#2552)

* This will fix sentry errors with no title by using the extra info as a title (#2565)

* Bugfix/android anr (#2603)

* updated Sentry SDK and increase the default timeout for ANR to be thrown  from 4 to 10 seconds #2498

* updated ANR reporting time to 8 seconds

* removed increased timeout and correct sentry integrations vesion

* updated pod dependencies

* remove typo (#2613)

* Upgrade swaps-controller v4 (#2586)

* updated lock files (#2614)

* Fix/respect custom spend limit on dapp approve modal (#2556)

* Add better initial state reset for permission edit modal

* Use spendLimitCustomValue for allowance

* minimumSpendLimit 1

* Remove minimumSpendLimit prop

* Get minimumSpendLimit from EditPermission component

* Add MINIMUM_VALUE const

* use export const

* Coerce minimumSpendLimit to number

* Log error

* Remove callback from initialState

Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>

* Improve rpc errors logging and removing user rejected errors (#2564)

* Improve rpc errors logging and removing user rejected errors

* Update for even more cases

* Add comments to code

* Add trackErrorAsAnalytics

* Use typeof

* Feature/update seed phrase wording (#2605)

* Move login strings to translation file

* replace seed phrase with Secret Recovery phrase

* Get an video working

* get video working off disk

* Add SeedPhraseVideo component

* Add TODO:

* Add SeedPhraseVideo to onboarding

* Update snapshots

* Add borderRadius

* cleanup

* Remove placeholder video and add recovery-phrase

* Add video-controls

* Add cover to video

* Add play button to cover

* adjust opacity to closer match design

* Add marginTop to video on settings page

* Remove subtitles for now

* Update few remaining instances

* Account for single word instances

* update snapshots

* Update snapshots

* RC v2.3.0 (#2621)

* bump version numbers

* update change log

* Implement 'hide zero balance token' setting for token balances on home screen (#2444)

* Implement 'hide zero balance token' setting for token balances on home screen

* Add localizations

* Refactor how balances are detected, add tests

* Fix lint, add spacing, create jest snapshots

* Fix test, lint

* Remove unnecessary proop from test

* Remove 'paymentChannelsEnabled' prop that doesn't belong in this patch

Co-authored-by: ricky <ricky.miller@gmail.com>

* Fix isZero is undefined (#2625)

* Fix isZero is undefined

* Update app/components/UI/Tokens/index.js

Co-authored-by: Esteban Miño <efmino@uc.cl>

* add optional chaining

Co-authored-by: Esteban Miño <efmino@uc.cl>

* Address yarn audit (#2633)

* updated change log (#2631)

* updated change log

* updated change log

* updated change log

* Exclude native asset from hiding when balance is zero (#2639)

* Fix undefined is not an object identities[selectedAddress].importTime (#2643)

* Fix undefined is not an object (evaluating 'identities[selectedAddress].importTime

* Use accountImportTime for consistency

* Safe navbar for iphone 12 (#2645)

* safenavbar

* Update app/util/Device.js

Co-authored-by: ricky <ricky.miller@gmail.com>

* mocks

* lint

* finally

Co-authored-by: ricky <ricky.miller@gmail.com>

* Fix missing seed phrase updates (#2657)

* Fix Balance undefined for deeplink payment requests (#2656)

* Check for transactionToName

* Account for own accounts

* Remove console.log

* Use account names from identities

* Remove async

* Add some safety

* Load video over the network (#2663)

* updated version code and change logs (#2664)

* updated version code and change logs

* update change log

* added export of iOS artifacts (#2667)

* added export of iOS artifacts

* updated destination directory

* Bump hosted-git-info from 2.8.8 to 2.8.9 (#2670)

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Key off accounts (#2669)

* Key off accounts

* Key off accounts in ChoosePassword as well

* Fix deploy contract and create token testnets (#2674)

* updated change logs

* upated version codes and change logs (#2675)

Co-authored-by: ricky <ricky.miller@gmail.com>
Co-authored-by: Minh <minhle@canva.com>
Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
Co-authored-by: Esteban Miño <efmino@uc.cl>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: andrepimenta <andrepimenta7@gmail.com>
Co-authored-by: Michael Standen <screaminghawk@gmail.com>
Co-authored-by: Ibrahim Taveras <ibrahimtaveras00@gmail.com>
Co-authored-by: Ibrahim Taveras <ibrahimtaveras@ibrahims-mbp.myfiosgateway.com>
Co-authored-by: David Walsh <davidwalsh83@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
rickycodes pushed a commit that referenced this issue Jan 31, 2022
@sethkfman
Bugfix/android anr (#2603)
78ff225 
* updated Sentry SDK and increase the default timeout for ANR to be thrown  from 4 to 10 seconds #2498

* updated ANR reporting time to 8 seconds

* removed increased timeout and correct sentry integrations vesion

* updated pod dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sethkfman sethkfman

Labels
type-bug Something isn't working
Projects
None yet
Milestone
Tooling Sprint
Development

Successfully merging a pull request may close this issue.

Bugfix/android anr MetaMask/metamask-mobile
3 participants
@andrepimenta @sethkfman @mobularay