Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Wyre minimum fee and minimum amount #1917

Merged
merged 5 commits into from
Nov 2, 2020
Merged

Update Wyre minimum fee and minimum amount #1917

merged 5 commits into from
Nov 2, 2020

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Oct 27, 2020 •
edited
Loading

Description
This PR updates minimum fee amount according to Wyre's fee structure and sets minimum purchase amount to $50.

@wachunei wachunei marked this pull request as ready for review October 27, 2020 19:43
@wachunei wachunei requested a review from a team as a code owner October 27, 2020 19:43
@omnat omnat added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) next release labels Oct 28, 2020
estebanmino
estebanmino approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ibrahimtaveras00
ibrahimtaveras00 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

Screen Shot 2020-10-28 at 9 09 53 PM

image

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 29, 2020
@estebanmino estebanmino merged commit 0acf4bb into MetaMask:develop Nov 2, 2020
@wachunei wachunei deleted the feature/wyre-onramp-min-fee branch November 2, 2020 17:25
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@wachunei @estebanmino
Update Wyre minimum fee and minimum amount (#1917)
0e4e178 
* Add min  fee to wyre

* Remove fees from wyre payment method selector

* Update minimum amount to

Co-authored-by: Esteban Miño <efmino@uc.cl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wachunei @estebanmino @ibrahimtaveras00 @omnat