Fix seedphrase handling in QRScanner #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
added
needs-dev-review
rickycodes
force-pushed
the
bugfix/qr-code-seedphrase-validation
branch
from
d517268
to
84f432d
Compare
rickycodes
removed
the
needs-dev-review
ibrahimtaveras00
added
next release
QA Passed
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As it stands importing from seed phrase when using a QR code that holds a 24 character mnemonic fails spectacularly:
(it would appear it's trying to handle it as a deeplink.)
this PR utilizes validators that were recently added to handle this properly.
Checklist
Issue
Resolves #???