Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@metamask/controllers@5.1.0 #2030

Merged
merged 4 commits into from
Dec 15, 2020
Merged

@metamask/controllers@5.1.0 #2030

merged 4 commits into from
Dec 15, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Dec 2, 2020

  • Minor version bump of @metamask/controllers

@rekmarks rekmarks requested a review from a team as a code owner December 2, 2020 17:36
estebanmino
estebanmino approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibrahimtaveras00 could you check currency conversions make sense? I believe is the only change that could affect the app

@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Dec 11, 2020
@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Dec 15, 2020
@estebanmino estebanmino merged commit ef9a9e2 into develop Dec 15, 2020
@estebanmino estebanmino deleted the @metamask/controllers@5.1.0 branch December 15, 2020 18:08
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@rekmarks @estebanmino
@metamask/controllers@5.1.0 (#2030)
888a398 
Co-authored-by: Esteban Miño <efmino@uc.cl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekmarks @estebanmino @ibrahimtaveras00