Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/tx to contract validation #2079

Merged
merged 3 commits into from
Jan 21, 2021
Merged

bugfix/tx to contract validation #2079

merged 3 commits into from
Jan 21, 2021

Conversation

estebanmino
Copy link
Contributor

Description

We have been validating contract addresses asking for the asset data, this is failing for some RPC networks since we're querying a contract that doesn't exist in those.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner December 17, 2020 17:39
@estebanmino estebanmino added type-bug Something isn't working needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Dec 17, 2020
@andrepimenta andrepimenta removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 12, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 21, 2021
@estebanmino estebanmino merged commit 115d28b into develop Jan 21, 2021
@estebanmino estebanmino deleted the bugfix/tx-to-contract-validation branch January 21, 2021 22:43
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix/tx to contract validation (#2079)
872ae67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wachunei wachunei wachunei approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estebanmino @wachunei @ibrahimtaveras00 @andrepimenta