patch validator via resolution #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rickycodes seems like a bunch of stuff moved around in the file which makes it hard to check. Could you identify what exactly changed/added here? |
rickycodes
force-pushed
the
bugfix/patch-validator
branch
from
3962219
to
7c80d5b
Compare
|
@adonesky1 ah yeah, i guess sorting and applying the patch at the same time wasn't the best move? 😓 should be nice and clear now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patches a vulnerability in the project. I've also taken the liberty of sorting the
package.jsonkey values.Somebody will need to do regression on payments to ensure this doesn't break anything.