Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Sync with Extension #3443

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Disable Sync with Extension #3443

merged 4 commits into from
Nov 23, 2021

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Nov 22, 2021 •
edited
Loading

Description

Temporarily disable sync with Extension on release builds.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3442

@sethkfman sethkfman requested a review from a team as a code owner November 22, 2021 17:08
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 22, 2021
rickycodes
rickycodes approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@rickycodes rickycodes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickycodes rickycodes removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 22, 2021
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 22, 2021
cortisiko
cortisiko approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@sethkfman sethkfman merged commit 46cd8e1 into develop Nov 23, 2021
@sethkfman sethkfman deleted the improvement/disable-sync-for-release branch November 23, 2021 16:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rickycodes rickycodes rickycodes approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable ‘Sync with extension’ feature
3 participants
@sethkfman @rickycodes @cortisiko