Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collectibles autodetection #3458

Merged
merged 15 commits into from
Dec 3, 2021
Merged

Fix collectibles autodetection #3458

merged 15 commits into from
Dec 3, 2021

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Nov 25, 2021 •
edited
Loading

Description

This PR includes controllers from MetaMask/core#636 and adds selectors

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3335

To do

  • Remove controllers from package json once they are released

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

gantunesr
gantunesr reviewed Nov 26, 2021
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll approve it when this is no longer a draft.

@wachunei wachunei marked this pull request as ready for review November 26, 2021 14:37
@wachunei wachunei requested a review from a team as a code owner November 26, 2021 14:37
@wachunei wachunei added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Nov 30, 2021
@wachunei
Copy link
Member Author

Reminder we need to remove controllers from package json once they are released

@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 30, 2021
gantunesr
gantunesr approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr mentioned this pull request Dec 3, 2021
Closed
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Dec 3, 2021
cortisiko
cortisiko approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@wachunei wachunei merged commit 8b0e915 into develop Dec 3, 2021
@wachunei wachunei deleted the fix/nft-autodetect branch December 3, 2021 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees

@wachunei wachunei

Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NFT Caching issue
4 participants
@wachunei @cortisiko @gantunesr @adonesky1