Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT asset display error, probably a cache issue. #3406

Closed
GoDotDotDot opened this issue Nov 11, 2021 · 9 comments
Closed

NFT asset display error, probably a cache issue. #3406

GoDotDotDot opened this issue Nov 11, 2021 · 9 comments
Labels
type-bug Something isn't working

Comments

@GoDotDotDot
Copy link

Describe the bug
I found that when I have more than 2 addresses with NFT on the Android side, then the cache situation occurs. For example, the wallet has 3 addresses, A, B and C. When both A and B have NFT assets, switching between A and B results in a wrong display of NFT assets for A and B. No problem when switching to C, C address does not have any NFT assets.

Screenshots
Address A:
image

Address B:
image

Address C:
image

To Reproduce
Steps to reproduce the behavior

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
Switching to address A displays the NFT assets under address A. Switching to address B displays the NFT assets under address B.

Smartphone (please complete the following information):

  • Device: iPhone 11 Pro
  • OS: iOS 15.0
  • App Version: 3.6.0

image


to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@GoDotDotDot GoDotDotDot added the type-bug Something isn't working label Nov 11, 2021
@GoDotDotDot
Copy link
Author

In fact, address A has only one NFT asset.
image

The rest are the assets of address B.

@gantunesr
Copy link
Member

Thanks for reporting this issue @GoDotDotDot, we're taking a look into this problem and I will follow up on the solution and the release in which it'll be included

@GoDotDotDot
Copy link
Author

I thought I'd try to debug it, too. @gantunesr

@GoDotDotDot
Copy link
Author

Thanks for reporting this issue @GoDotDotDot, we're taking a look into this problem and I will follow up on the solution and the release in which it'll be included

I opened a PR and you can review it if you have time. #3428 @gantunesr

@gantunesr
Copy link
Member

Hey @GoDotDotDot, I have reviewed and tested your PR and this development could solve this issue but it would introduce another bugs. We have already found the origin of this bug in the controllers module and a fix is under development right now

@GoDotDotDot
Copy link
Author

GoDotDotDot commented Nov 20, 2021

Hey @GoDotDotDot, I have reviewed and tested your PR and this development could solve this issue but it would introduce another bugs. We have already found the origin of this bug in the controllers module and a fix is under development right now

Yes, according to my pr #3428:

I have noticed that the controller repository has been updated to 19.0, but Metamask-mobile is still using 18.0. I think the best thing to do is to modify the AssetsDetectionController.detectAssets method and update the collectibleContracts and collectibles attr according to the changing of address. But the current solution is also acceptable.

I also found this problem because I was a bit confused about the version number of controller module, so I didn't deal with it. Thank you. @gantunesr

@gantunesr
Copy link
Member

Hi @GoDotDotDot, thank you for your input in this issue! Here's an update on the current development.

There was two problems related to this issue, the first one was the wrong assignation of NFTs to different account and/or networks, the solution for this is in the PR #3458 which will be included in the v3.8.0.

The second issue is about showing NFTs which the user is not the owner, this development will be addressed in the ticket 3444

@GoDotDotDot
Copy link
Author

Hi @GoDotDotDot, thank you for your input in this issue! Here's an update on the current development.

There was two problems related to this issue, the first one was the wrong assignation of NFTs to different account and/or networks, the solution for this is in the PR #3458 which will be included in the v3.8.0.

The second issue is about showing NFTs which the user is not the owner, this development will be addressed in the ticket 3444

thx.

@gantunesr
Copy link
Member

I'll close this issue for now. For updates check #3444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants