Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Jazz icons constantly changing #4503

Merged
merged 9 commits into from
Aug 12, 2022
Merged

Conversation

tommasini
Copy link
Contributor

Description
The jazz icon on the Send To screen in the Send Flow was changing when we look for an ENS, because the Jazz Icon component https://www.npmjs.com/package/react-native-jazzicon, was receiving an ens name on the address prop instead of an eth address.

Proposed Solution
When we look for an ENS name, we resolve that ens name and send it to the Jazz Icon component. This way the Jazz Icon will no longer change.

Code Impact
The changes it was only on the level of the SendTo component, the impact of this code is low.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings
Issue:
https://user-images.githubusercontent.com/46944231/168823545-0ba7bc06-2334-48e1-9575-53bc60bc9902.mp4

Solution:
https://user-images.githubusercontent.com/46944231/168823730-1ca0ba3e-77ad-4c9d-b8e2-0565dba99f78.mp4

Test Cases
Case 1:

  • In general settings choose the jazz icons
  • Go to send screen
  • Write an ens name (example: 'evan.eth')
  • Press next (To the amount screen)
  • Press back (To the send screen again)
  • The icons must be the same

Issue

Progresses #4353

@tommasini tommasini requested a review from a team as a code owner June 15, 2022 12:50
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Mobile QA board labels Jun 15, 2022
@tommasini tommasini changed the title jazz icons are not changing anymore [FIX] Jazz icons constantly changing Jun 15, 2022
@tommasini tommasini marked this pull request as draft June 15, 2022 13:10
@tommasini tommasini marked this pull request as ready for review June 15, 2022 17:28
@chrisleewilcox chrisleewilcox self-assigned this Jun 16, 2022
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. Mobile QA board labels Jun 16, 2022
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreahaku andreahaku added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 4, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 12, 2022
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ticket is 🌮 🌮

Things I tested:

@cortisiko cortisiko added QA Passed A successful QA run through has been done release-5.7.0 PRs for release 5.7.0 and removed QA in Progress QA has started on the feature. labels Aug 12, 2022
@cortisiko cortisiko merged commit f33cace into main Aug 12, 2022
@cortisiko cortisiko deleted the fix/4353-jazzicons-changes branch August 12, 2022 22:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-5.7.0 PRs for release 5.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants