[IMPROVEMENT] safeNumberToBN Method #4634
Merged
+152
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantunesr
added
needs-dev-review
gantunesr
added
needs-qa
sethkfman
added
release-5.6.0
AlexHerman1
added
CS-reported
cortisiko
added
QA in Progress
cortisiko
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
Things I tested:
- Sending ERC-20 tokens (integer amount and decimals)
- Swapping ERC-20 to ERC-20
- Swapping Native to ERC-20
- Speeding up/ cancelling transactions
- Setting custom gas limits, max priority fees on transactions
- Deploying contracts
- Approving contracts (I edited the custom limits to be non-integer)
- Keystone transactions: sending tokens, minting NFT’s
- I verified that [FIX] Fixes renderFromGwei related crashes #3538 did not regress.
With that being said, This PR is 🌮 🌮
cortisiko
added
QA Passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there's an issue in the app where a value
0xNaNis getting passed to the methodsafeNumberToBN. This PR improve the logic of the method to avoid the error and expands the testing around it to minimize the probability of those errors occurring again. The next step after this development is to check where the0xNaNis getting originated.Screenshots/Recordings
NA
Issue
Progresses https://github.com/MetaMask/mobile-planning/issues/313
Checklist