Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Remember me strings #4784

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Hide Remember me strings #4784

merged 2 commits into from
Aug 2, 2022

Conversation

owencraston
Copy link
Contributor

@owencraston owencraston commented Aug 2, 2022

Description

  • These are the strings for the hide remember me PR
    1. What is the reason for the change?
  • so we can ship these earlier and get the translations ASAP since this is such a sensitive change
    2. What is the improvement/solution?
  • adding the strings as a separate PR so we can ship it independently of the fix
  • after this is merged I will rebase

The strings were agreed upon here

Screenshots/Recordings
these are the modal designs, we have no designs for the settings toggle
Screen Shot 2022-08-02 at 12 54 40 PM

Issue

Progresses #4194

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@owencraston owencraston requested a review from a team as a code owner August 2, 2022 16:26
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@owencraston owencraston mentioned this pull request Aug 2, 2022
3 tasks
@gantunesr gantunesr added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Aug 2, 2022
locales/languages/en.json Outdated Show resolved Hide resolved
@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels Aug 2, 2022
@coreyjanssen
Copy link

coreyjanssen commented Aug 2, 2022

Editing my original comment. Looks good, but can we modify the content slightly? otherwise all good on this from a content perspective.

title: Enter your password to turn off Remember me
action: Turn off Remember me

As for the turning Remember me on strings, can we strike the quotation marks and modify the content:

Title: Turn on Remember me
enable_remember_me_description: When Remember me is on, anyone with access to your phone can access your MetaMask account.

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.5.0 PRs for v5.5.0 release and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 2, 2022
@gantunesr
Copy link
Member

This PR does not affect the code of next release

@owencraston owencraston merged commit f5dd908 into main Aug 2, 2022
@owencraston owencraston deleted the hide-remember-me-strings branch August 2, 2022 17:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2022
@vpintorico vpintorico added release-5.6.0 PRs for v5.6.0 release and removed release-5.5.0 PRs for v5.5.0 release labels Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.6.0 PRs for v5.6.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants