Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix password not being set as authentication type for login metrics #4824

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

owencraston
Copy link
Contributor

@owencraston owencraston commented Aug 9, 2022

Description

  • this issue builds off the work done in the initial setup PR for login metrics
  • @plasmacorral discovered this bug while doing for Hide remember me #4305
    Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
    1. What is the reason for the change?
  • The authentication type analytics property of the user was never being set to password even if the user was using password as the method to login
  • this side effect of this was that when a user disabled remember me, the data would not reflect that since it would fall back to password login
    2. What is the improvement/solution?
  • call Analytics.applyUserProperty(AUTHENTICATION_TYPE.PASSWORD); inside the SecureKeychain.resetGenericPassword method
  • why?
    • because this is the method we use to "reset" the login credentials to its default state...which is password
    • this is how we turn off remember me
    • this is how we turn off biometrics
    • this is what is called when you lock the wallet
    • placing the logic in here means we will never miss a case where the user is using password as their login option

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@owencraston owencraston requested a review from a team as a code owner August 9, 2022 20:36
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@owencraston owencraston added type-bug Something isn't working metrics Code Impact - Low Minor code change that can safely applied to the codebase team-accounts labels Aug 9, 2022
android/app/build.gradle Outdated Show resolved Hide resolved
bitrise.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owencraston
Copy link
Contributor Author

Here is a video walking through all the authentication methods. The data doe snot instantly populate in mixpanel but you can see after a few refreshes it always shows the correct value.
https://user-images.githubusercontent.com/22918444/183942529-18fca64d-5b7f-4370-8a51-819e6b901516.mov

@plasmacorral plasmacorral added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Aug 10, 2022
@owencraston owencraston merged commit d67ae60 into main Aug 10, 2022
@owencraston owencraston deleted the fix/update-auth-type-metrics branch August 10, 2022 16:29
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Code Impact - Low Minor code change that can safely applied to the codebase No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-accounts type-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants