Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-Ramp: Fix 1.3.1 creating undefined custom order ids #5269

Merged
merged 17 commits into from
Nov 22, 2022
Merged

On-Ramp: Fix 1.3.1 creating undefined custom order ids #5269

merged 17 commits into from
Nov 22, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Nov 17, 2022 •
edited

> ⚠️ Rebase to main once refactor/onramp-buy-actions-auth-url is merged

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PRs avoids creating undefined customOrderId in the useInAppBrowser hook

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added blocked needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.12.0 labels Nov 17, 2022
@wachunei wachunei requested a review from a team as a code owner November 17, 2022 23:51
@wachunei wachunei mentioned this pull request Nov 17, 2022
Merged
3 tasks
Cal-L
Cal-L reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 17, 2022
Base automatically changed from refactor/onramp-buy-actions-auth-url to main November 22, 2022 14:36
@wachunei wachunei removed the blocked label Nov 22, 2022
@wachunei wachunei requested a review from Cal-L November 22, 2022 16:13
@wachunei
Copy link
Member Author

hey @Cal-L with the rebase to main your review went stale, can you please re-review? 🙏

Cal-L
Cal-L approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei merged commit fe726c1 into main Nov 22, 2022
@wachunei wachunei deleted the fix/onramp-1.3.1-undefined-custom-order-id branch November 22, 2022 20:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-5.12.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wachunei @Cal-L