Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Remove deeplink warning for SDK and SDK as dependency #5449

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

andreahaku
Copy link
Member

@andreahaku andreahaku commented Jan 4, 2023

  • makes MM SDK Communication layer package a dependency and no longer embeds it
  • when scanning a QRCode, removes the warning if the deep link is an SDK connection one (URL starting with https://metamask.app.link/connect?)

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Scanning a MM SDK Connection QRCode with the app, should no longer show the warning message but show the modal to establish the connection right away.
It should keep showing the warning for other urls.
To test this, simply scan a QRCode for a MM SDK connection and it should now show the warning.

Also, the MM SDK Communication layer is no longer part of the code, but back to be a dependency.
To test this, simply try to establish a connection to a dapp using the SDK and it should connect and work as expected.

Screenshots/Recordings
Scanning a MM SDK Connection QRCode with the app, should no longer show the following warning message but show the modal to establish the connection right away:
image

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@andreahaku andreahaku added deeplinks Deeplinks related issue or bug team-sdk SDK team labels Jan 4, 2023
@andreahaku andreahaku self-assigned this Jan 4, 2023
@andreahaku andreahaku changed the title Remove deeplink warning for SDK and SDK as dependency [IMPROVEMENT] Remove deeplink warning for SDK and SDK as dependency Jan 4, 2023
@andreahaku andreahaku marked this pull request as ready for review January 4, 2023 12:06
@andreahaku andreahaku requested a review from a team as a code owner January 4, 2023 12:06
@andreahaku andreahaku added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jan 4, 2023
@andreahaku andreahaku added Code Impact - Low Minor code change that can safely applied to the codebase release-5.14.0 Issue or pull request that will be included in release 5.14.0 labels Jan 4, 2023
Copy link
Contributor

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed!

@andreahaku andreahaku merged commit e7f5f00 into main Jan 10, 2023
@andreahaku andreahaku deleted the feature/sdk-deeplink-warning-removal-and-dependency branch January 10, 2023 14:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
@andreahaku andreahaku removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Code Impact - Low Minor code change that can safely applied to the codebase deeplinks Deeplinks related issue or bug release-5.14.0 Issue or pull request that will be included in release 5.14.0 team-sdk SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants