Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Remove deeplink warning for SDK and SDK as dependency #5449

Merged
merged 2 commits into from
Jan 10, 2023
Merged

[IMPROVEMENT] Remove deeplink warning for SDK and SDK as dependency #5449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a94d66d
Makes MM SDK Communication layer package a dependency and no longer e…
andreahaku Jan 4, 2023
44d6eac
White lists MM SDK Connection deeplinks from QRCode scanning url redi…
andreahaku Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/components/Views/QRScanner/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import { getURLProtocol } from '../../../util/general';
import Engine from '../../../core/Engine';
import Routes from '../../../constants/navigation/Routes';
import { PROTOCOLS } from '../../../constants/deeplinks';
import { MM_SDK_DEEPLINK } from '../../../constants/urls';
import styles from './styles';
import {
createNavigationDetails,
Expand Down Expand Up @@ -135,8 +136,9 @@ const QRScanner = () => {

const contentProtocol = getURLProtocol(content);
if (
contentProtocol === PROTOCOLS.HTTP ||
contentProtocol === PROTOCOLS.HTTPS
(contentProtocol === PROTOCOLS.HTTP ||
contentProtocol === PROTOCOLS.HTTPS) &&
!content.startsWith(MM_SDK_DEEPLINK)
) {
const redirect = await showAlertForURLRedirection(content);

Expand Down
3 changes: 3 additions & 0 deletions app/constants/urls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,6 @@ export const MM_APP_STORE_LINK =
'itms-apps://apps.apple.com/app/metamask-blockchain-wallet/id1438144202';

export const MM_PLAY_STORE_LINK = `market://details?id=${AppConstants.BUNDLE_IDS.ANDROID}`;

// SDK
export const MM_SDK_DEEPLINK = `https://${AppConstants.MM_UNIVERSAL_LINK_HOST}/connect?`;
71 changes: 0 additions & 71 deletions app/core/RemoteConnection/ECIES.ts
View file
Open in desktop

This file was deleted.

115 changes: 0 additions & 115 deletions app/core/RemoteConnection/KeyExchange.ts
View file
Open in desktop

This file was deleted.

Loading