-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MC 0.5][FEATURE] Token list with network logo and token name #6020
Conversation
This reverts commit 6157bf3.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Co-authored-by: Samuel Salas <samuel.salas.reyes@gmail.com>
Detox and Webdriver.IO Test passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮 🌮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This pull request aims to improve the token list, showing the name of the tokens and the network logo, it removes the default '$0.00' of token balances and it's switching them to a skeleton loader.
It was developed unit tests to the components as well.
This PR also have performance improvement on how we fetch the tokens balances.
Technical Details
This PR for core repo aims to update the Tokens name:
https://github.com/MetaMask/core/pull/1127/files#diff-7ada7b099f6bcc6f3d4acd71f94b604636abd22cc556a76dbe7b3e610b1d9233
Draft created for performance improve
MetaMask/core#1128
Test Steps (All of them are recorded in the Screenshots/Recording section)
Non-recorded but tested
Screenshots/Recordings
Full behaviour on light mode simulator iPhone 14 pro (iOS16.2)
Full behaviour on dark mode physical device Huawei p30 pro (Android 11)
Test Cases
User imports tokens via token autocomplete across supported networks: https://recordit.co/fRCLO6haNT
User imports tokens by contract address: https://recordit.co/kntnmF0N5n
User imports token on network A then switches to network B: https://recordit.co/nEedgiJEfp
User imports token via asset watcher: https://recordit.co/iXi6IXEwpH
User performs a swap via a dapp then imports token: http://recordit.co/iXtKpUAe2f
(On the next both recording, there is only the part of the feature but I updated the app from a past version)
User updates the app to this feature with token detection off: https://recordit.co/SGyPxQ21Bl
User updates the app to this feature with token detection already enabled: https://recordit.co/G2iRCJQEEo
User imports an account to wallet then removes that imported account: https://recordit.co/iQEaWdhIPT
To be improved
Issue
Progresses #
Checklist