Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MC 0.5][FEATURE] Total balance and portfolio button changed #6051

Merged
merged 6 commits into from
Apr 20, 2023
Merged

[MC 0.5][FEATURE] Total balance and portfolio button changed #6051

merged 6 commits into from
Apr 20, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Mar 27, 2023 •
edited

Description
This PR aims to move the total fiat balance and the portfolio button to the token list.

Technical details
The scroll view was changed to a flat list component on the tokens tab and NFTs tab.

Screenshots/Recordings
Scenario: Total fiat balance on Wallet view should be the sum of both the native currency and token balances: https://recordit.co/I2QdDfLe7z

Scenario: Should open Pdapp after tapping on the Portfolio button from the Wallet view - https://recordit.co/1yNuRfo4Kk

Issue

Progresses #

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini mentioned this pull request Mar 31, 2023
Merged
3 tasks
@tommasini tommasini marked this pull request as ready for review April 5, 2023 15:24
@tommasini tommasini requested a review from a team as a code owner April 5, 2023 15:24
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Apr 5, 2023
sethkfman
sethkfman approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 5, 2023
@sethkfman sethkfman added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-mobile-client labels Apr 7, 2023
@gauthierpetetin gauthierpetetin changed the title [FEATURE][MC] Total balance and portfolio button changed [MC 0.5][FEATURE] Total balance and portfolio button changed Apr 10, 2023
@SamuelSalas SamuelSalas added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 17, 2023
@SamuelSalas SamuelSalas mentioned this pull request Apr 18, 2023
Merged
3 tasks
@SamuelSalas SamuelSalas added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Apr 19, 2023
@tommasini tommasini merged commit c00fed4 into main Apr 20, 2023
13 checks passed
@tommasini tommasini deleted the feature/651-update-total-fiat branch April 20, 2023 02:12
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-6.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tommasini @sethkfman @SamuelSalas