Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MC 0.5][FEATURE] Update account section with card #6085

Merged
merged 25 commits into from
Apr 25, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Mar 31, 2023

Description
This PR aims to replace the account overview for a new one
This PR it's blocked by this PR and this one #5992

Screenshots/Recordings

Account information should be visible on the Wallet screen: (The most updated UI is on the screenshots, recordings contain the logic features)

image

Should be able to access account selector while on the Wallet view: https://recordit.co/okPc8Ju08x

Should be able to copy account address to clipboard from Wallet view: https://recordit.co/K58p0llmpH

importing account with ENS name via private key. Does ENS name appear in account card: https://recordit.co/Nhagk5LYRs

On boarding wizard updated on this PR: https://recordit.co/uAJvpK46IJ
If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini marked this pull request as ready for review March 31, 2023 14:18
@tommasini tommasini requested a review from a team as a code owner March 31, 2023 14:18
@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 31, 2023
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 5, 2023
@sethkfman sethkfman added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-mobile-client labels Apr 7, 2023
@gauthierpetetin gauthierpetetin changed the title [FEATURE][MC] Update account section with card [MC 0.5][FEATURE] Update account section with card Apr 10, 2023
@SamuelSalas SamuelSalas added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 20, 2023
tommasini and others added 2 commits April 25, 2023 01:35
* fix detox and appium test scripts

* Fix detox and appium test cases

* Update snapshots
@SamuelSalas SamuelSalas added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Apr 25, 2023
@tommasini tommasini merged commit fe884bb into main Apr 25, 2023
16 checks passed
@tommasini tommasini deleted the feature/713-update-account-section branch April 25, 2023 22:29
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-6.6.0 PR for release 6.6.0 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants