-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MC 0.5][FEATURE] Update account section with card #6085
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
tommasini
added
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Mar 31, 2023
Fatxx
reviewed
Apr 4, 2023
sethkfman
reviewed
Apr 5, 2023
sethkfman
reviewed
Apr 5, 2023
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
sethkfman
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tommasini
added
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
and removed
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
labels
Apr 5, 2023
sethkfman
added
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
and removed
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
team-mobile-client
labels
Apr 7, 2023
gauthierpetetin
changed the title
[FEATURE][MC] Update account section with card
[MC 0.5][FEATURE] Update account section with card
Apr 10, 2023
SamuelSalas
added
QA in Progress
QA has started on the feature.
and removed
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
labels
Apr 20, 2023
tommasini
added
release-6.6.0
PR for release 6.6.0
team-mobile-client
and removed
release-6.5.0
labels
Apr 24, 2023
3 tasks
* fix detox and appium test scripts * Fix detox and appium test cases * Update snapshots
SamuelSalas
added
QA Passed
A successful QA run through has been done
and removed
QA in Progress
QA has started on the feature.
labels
Apr 25, 2023
gauthierpetetin
added
the
team-mobile-ux
DEPRECATED: please use "team-wallet-ux" label instead
label
Feb 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
QA Passed
A successful QA run through has been done
release-6.6.0
PR for release 6.6.0
team-mobile-ux
DEPRECATED: please use "team-wallet-ux" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to replace the account overview for a new one
This PR it's blocked by this PR and this one #5992
Screenshots/Recordings
Account information should be visible on the Wallet screen: (The most updated UI is on the screenshots, recordings contain the logic features)
Should be able to access account selector while on the Wallet view: https://recordit.co/okPc8Ju08x
Should be able to copy account address to clipboard from Wallet view: https://recordit.co/K58p0llmpH
importing account with ENS name via private key. Does ENS name appear in account card: https://recordit.co/Nhagk5LYRs
On boarding wizard updated on this PR: https://recordit.co/uAJvpK46IJ
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist