Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devDeps): Use updated fork of oss-attribution-generator #6306

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 1, 2023

Description

This package was last updated in 2018, by now over 5 years ago.
This replaces it with an updated fork with several obsolete dependencies removed or updated.

npmdiff

Blocked by

Checklist

  • Tests are included if applicable
  • Any added code is fully documented

@legobeat legobeat added the dependencies Pull requests that update a dependency file label May 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented May 1, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: license-checker@25.0.1, @metamask/oss-attribution-generator@2.0.1

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat changed the title devDeps: Use updated fork for oss-attribution-generator devDeps: Use updated fork pf oss-attribution-generator May 1, 2023
@legobeat legobeat changed the title devDeps: Use updated fork pf oss-attribution-generator devDeps: Use updated fork of oss-attribution-generator May 1, 2023
@legobeat legobeat force-pushed the devdeps-oss-attribution-generator branch from 6fea769 to 7c59d16 Compare May 2, 2023 23:11
@legobeat legobeat force-pushed the devdeps-oss-attribution-generator branch 2 times, most recently from e80d2ba to a9564e4 Compare May 3, 2023 02:10
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Aug 1, 2023
@legobeat
Copy link
Contributor Author

legobeat commented Aug 1, 2023

@github-actions: Not stale but waiting for MetaMask/oss-attribution-generator#7

@legobeat legobeat removed the stale Issues that have not had activity in the last 90 days label Aug 1, 2023
@legobeat legobeat force-pushed the devdeps-oss-attribution-generator branch from a9564e4 to 7b40575 Compare October 3, 2023 01:54
@legobeat legobeat changed the title devDeps: Use updated fork of oss-attribution-generator chore(devDeps): Use updated fork of oss-attribution-generator Oct 3, 2023
@socket-security
Copy link

socket-security bot commented Oct 3, 2023

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/oss-attribution-generator 2.0.1 shell +10 372 kB

🚮 Removed packages: oss-attribution-generator@1.7.1

@legobeat
Copy link
Contributor Author

legobeat commented Oct 3, 2023

@SocketSecurity ignore license-checker@25.0.1

shell access ok

@legobeat legobeat force-pushed the devdeps-oss-attribution-generator branch from 7b40575 to c8c4dff Compare October 3, 2023 03:38
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (13130e3) 34.61% compared to head (a458d40) 34.61%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6306   +/-   ##
=======================================
  Coverage   34.61%   34.61%           
=======================================
  Files        1019     1019           
  Lines       27193    27193           
  Branches     2218     2218           
=======================================
  Hits         9413     9413           
  Misses      17289    17289           
  Partials      491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat marked this pull request as ready for review October 3, 2023 07:31
@legobeat legobeat requested a review from a team as a code owner October 3, 2023 07:31
@legobeat legobeat requested a review from leotm October 3, 2023 07:31
@legobeat legobeat force-pushed the devdeps-oss-attribution-generator branch 4 times, most recently from 255a22c to 5b7e96e Compare October 13, 2023 06:45
@legobeat legobeat force-pushed the devdeps-oss-attribution-generator branch from 5b7e96e to c5daa09 Compare October 16, 2023 00:49
Copy link
Contributor

@leotm leotm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work 💪 and thx for tidying up the resolutions

noticed on main running yarn build:attribution and yarn test:attribution-check

# ...
processing zip-stream@4.1.0
processing zip-stream for authors and licenseText
processing zxcvbn@4.4.2
processing zxcvbn for authors and licenseText
@metamask/react-native-button: unable to locate package.json
error Command failed with exit code 1.

and https://github.com/MetaMask/metamask-mobile/blob/main/attribution.txt hasn't been updated since last year (cc @wachunei spotted last update was yours), so this could be why
but not worth raising as a v1.7.1 issue since being replaced by v2.0.0

then in this pr (v2.0.0) running yarn build:attribution and yarn test:attribution-check

# ...
processing @metamask/preferences-controller for authors and licenseText
processing @metamask/preferences-controller@4.4.0
processing @metamask/preferences-controller for authors and licenseText
processing @metamask/react-native-button@2.3.0
TypeError: Assignment to constant variable.
    at Object.<anonymous> (/Users/leo/Documents/GitHub/metamask-mobile/node_modules/@metamask/oss-attribution-generator/index.js:115:31)
    at Array.map (<anonymous>)
    at /Users/leo/Documents/GitHub/metamask-mobile/node_modules/@metamask/oss-attribution-generator/index.js:105:35
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
error Command failed with exit code 1.

so perhaps worth raising an issue to fix in v2.0.1 then update to that as follow-up?

package.json Outdated Show resolved Hide resolved
@legobeat
Copy link
Contributor Author

legobeat commented Oct 17, 2023

@leotm Good catches!

@legobeat legobeat force-pushed the devdeps-oss-attribution-generator branch 3 times, most recently from 20523bc to 9c09a1b Compare October 18, 2023 09:51
@legobeat legobeat marked this pull request as ready for review October 18, 2023 09:51
@legobeat legobeat requested a review from leotm October 18, 2023 09:51
@legobeat legobeat force-pushed the devdeps-oss-attribution-generator branch from 9c09a1b to a458d40 Compare October 18, 2023 09:51
@legobeat legobeat force-pushed the devdeps-oss-attribution-generator branch from a458d40 to b07906e Compare October 18, 2023 10:14
@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @metamask/oss-attribution-generator@2.0.1

@legobeat legobeat merged commit cd15dab into MetaMask:main Oct 18, 2023
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
@legobeat legobeat deleted the devdeps-oss-attribution-generator branch October 25, 2023 03:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file team-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants