Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix require misname of @metamask/react-native-button #7530

Merged
merged 7 commits into from
Jan 18, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 18, 2023

Description

  • The package is now named @metask/react-native-button. This fixes the dependency field in the manifest as well as requires and patch accordingly.
    • chore: expand jest transformIgnorePatterns to cover new package name

Related issues

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Oct 18, 2023
@legobeat legobeat marked this pull request as ready for review October 18, 2023 06:09
@legobeat legobeat requested a review from a team as a code owner October 18, 2023 06:09
@socket-security
Copy link

socket-security bot commented Oct 18, 2023

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/react-native-button 3.0.0 None +0 7.93 kB lgbot

🚮 Removed packages: react-native-button@2.3.0

@socket-security
Copy link

socket-security bot commented Oct 18, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/react-native-button@3.0.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore-all

@legobeat legobeat changed the title deps: fix require misname of @metamask/react-native-button fix: fix require misname of @metamask/react-native-button Oct 18, 2023
@legobeat legobeat marked this pull request as draft October 18, 2023 06:25
@wachunei
Copy link
Member

Should this include v3 and remove the patch as well?

@legobeat

This comment was marked as resolved.

@legobeat

This comment was marked as resolved.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb51857) 39.83% compared to head (e24f3dd) 39.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7530   +/-   ##
=======================================
  Coverage   39.83%   39.83%           
=======================================
  Files        1233     1233           
  Lines       29821    29821           
  Branches     2840     2840           
=======================================
  Hits        11880    11880           
  Misses      17252    17252           
  Partials      689      689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat marked this pull request as ready for review October 25, 2023 06:51
@legobeat legobeat requested a review from leotm October 25, 2023 06:51
@legobeat legobeat force-pushed the fix-react-native-button branch 4 times, most recently from f202f60 to bb6c597 Compare October 30, 2023 00:55
wachunei
wachunei previously approved these changes Nov 10, 2023
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legobeat
Copy link
Contributor Author

legobeat commented Nov 15, 2023

SonarCloud Code Analysis is not reporting back and blocking merge

@Cal-L
Copy link
Contributor

Cal-L commented Nov 20, 2023

Could you provide some screenshots or vids showing that the button looks line/is working?

@legobeat
Copy link
Contributor Author

legobeat commented Nov 20, 2023

Could you provide some screenshots or vids showing that the button looks line/is working?

I don't have working setup to do that locally right now, unfortunately. Could you help me with this?

@Cal-L
Copy link
Contributor

Cal-L commented Nov 21, 2023

Looks good -
image

@Cal-L
Copy link
Contributor

Cal-L commented Nov 21, 2023

Started e2e smoke - https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c1c6a955-1dbb-42b9-a4d8-f0236e02dff5

@Cal-L Cal-L added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead and removed No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels Nov 21, 2023
@legobeat legobeat requested a review from a team November 29, 2023 11:13
@sethkfman sethkfman added release-7.15.0 Issue or pull request that will be included in release 7.15.0 and removed regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead labels Jan 11, 2024
@legobeat legobeat requested a review from a team January 11, 2024 16:55
@legobeat legobeat merged commit 99ed5ba into MetaMask:main Jan 18, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
@chrisleewilcox chrisleewilcox added release-7.16.0 Issue or pull request that will be included in release 7.16.0 and removed release-7.15.0 Issue or pull request that will be included in release 7.15.0 labels Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants