-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix require misname of @metamask/react-native-button #7530
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7fd1c30
to
16f551d
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: react-native-button@2.3.0 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore-all |
16f551d
to
8dc51a6
Compare
Should this include v3 and remove the patch as well? |
This comment was marked as resolved.
This comment was marked as resolved.
8dc51a6
to
74e02bd
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7530 +/- ##
=======================================
Coverage 39.83% 39.83%
=======================================
Files 1233 1233
Lines 29821 29821
Branches 2840 2840
=======================================
Hits 11880 11880
Misses 17252 17252
Partials 689 689 ☔ View full report in Codecov by Sentry. |
fce56a7
to
fe303ac
Compare
fe303ac
to
5f820d1
Compare
f202f60
to
bb6c597
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
b53ac08
to
7b2f895
Compare
Could you provide some screenshots or vids showing that the button looks line/is working? |
I don't have working setup to do that locally right now, unfortunately. Could you help me with this? |
4422f91
to
bc56723
Compare
Description
@metask/react-native-button
. This fixes the dependency field in the manifest as well as requires and patch accordingly.transformIgnorePatterns
to cover new package nameRelated issues
Pre-merge author checklist
Pre-merge reviewer checklist