Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Update Button's pressed and disabled states #6727

Merged
merged 13 commits into from
Aug 31, 2023

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Jun 29, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

  • Updated ButtonBase to take in node for label
  • Updated disabled states for all button to have 0.5 opacity
  • Updated pressed states for all button
  • Updated ButtonLink to properly use TouchableOpacity when size is auto
  • Added more colors to Text and Icon

Screenshots/Recordings

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-31.at.09.42.21.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-31.at.09.44.24.mp4

Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 09 53 45
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 09 56 38
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 09 56 38
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 09 56 39
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 09 56 50
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 09 56 57
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 09 57 02
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 09 57 06
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 09 57 12
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 10 02 00
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 10 02 02
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 10 02 09
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 10 02 11
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 10 02 18
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 10 08 19
Simulator Screen Shot - iPhone 14 Pro - 2023-06-29 at 10 08 22

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile team-design-system labels Jun 29, 2023
@brianacnguyen brianacnguyen self-assigned this Jun 29, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen changed the title Update Button/ButtonIcon's pressed and disabled states style: Update Button/ButtonIcon's pressed and disabled states Jun 29, 2023
@socket-security
Copy link

socket-security bot commented Jun 29, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/design-tokens 1.11.1...1.12.0 None +0/-0 113 kB gudahtt

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

68.1% 68.1% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs a rebase?

@brianacnguyen brianacnguyen requested a review from a team as a code owner August 2, 2023 21:20
ios/Podfile.lock Outdated Show resolved Hide resolved
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be broken up into smaller PRs for easier review? For instance we could do the ButtonIcon updates in one PR and the ButtonBase, ButtonLink updates in another. Another suggestion is to do a screencast rathe that screenshots so the PR description isn't so long 😅

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Patch coverage: 55.10% and project coverage change: +0.03% 🎉

Comparison is base (7fa438e) 32.83% compared to head (d978b3c) 32.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6727      +/-   ##
==========================================
+ Coverage   32.83%   32.87%   +0.03%     
==========================================
  Files         998      998              
  Lines       26674    26711      +37     
  Branches     2092     2098       +6     
==========================================
+ Hits         8758     8780      +22     
- Misses      17498    17509      +11     
- Partials      418      422       +4     
Files Changed Coverage Δ
...utton/foundation/ButtonBase/ButtonBase.stories.tsx 0.00% <0.00%> (ø)
.../Button/variants/ButtonLink/ButtonLink.stories.tsx 0.00% <ø> (ø)
...ton/variants/ButtonPrimary/ButtonPrimary.styles.ts 85.71% <ø> (ø)
...variants/ButtonSecondary/ButtonSecondary.styles.ts 71.42% <0.00%> (+8.92%) ⬆️
...p/component-library/components/Icons/Icon/Icon.tsx 51.61% <0.00%> (-12.39%) ⬇️
.../Buttons/Button/variants/ButtonLink/ButtonLink.tsx 52.63% <28.57%> (-11.66%) ⬇️
...utton/variants/ButtonSecondary/ButtonSecondary.tsx 52.94% <33.33%> (-10.70%) ⬇️
...onent-library/components/Texts/Text/Text.styles.ts 42.85% <33.33%> (-2.60%) ⬇️
...ns/Button/variants/ButtonPrimary/ButtonPrimary.tsx 61.53% <50.00%> (-2.10%) ⬇️
...tton/foundation/ButtonBase/ButtonBase.constants.ts 85.71% <100.00%> (+5.71%) ⬆️
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianacnguyen brianacnguyen changed the title style: Update Button/ButtonIcon's pressed and disabled states style: Update Button's pressed and disabled states Aug 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

65.3% 65.3% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brianacnguyen brianacnguyen merged commit 664977c into main Aug 31, 2023
13 checks passed
@brianacnguyen brianacnguyen deleted the morph/update-button-disablestate branch August 31, 2023 22:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 31, 2023
@metamaskbot metamaskbot added the release-7.7.0 Issue or pull request that will be included in release 7.7.0 label Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.7.0 Issue or pull request that will be included in release 7.7.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants