-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Update Button's pressed and disabled states #6727
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this needs a rebase?
…to morph/update-button-disablestate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be broken up into smaller PRs for easier review? For instance we could do the ButtonIcon
updates in one PR and the ButtonBase
, ButtonLink
updates in another. Another suggestion is to do a screencast rathe that screenshots so the PR description isn't so long 😅
app/component-library/components-temp/CustomSpendCap/__snapshots__/CustomSpendCap.test.tsx.snap
Show resolved
Hide resolved
…to morph/update-button-disablestate
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6727 +/- ##
==========================================
+ Coverage 32.83% 32.87% +0.03%
==========================================
Files 998 998
Lines 26674 26711 +37
Branches 2092 2098 +6
==========================================
+ Hits 8758 8780 +22
- Misses 17498 17509 +11
- Partials 418 422 +4
☔ View full report in Codecov by Sentry. |
…to morph/update-button-disablestate
Kudos, SonarCloud Quality Gate passed! 0 Bugs 65.3% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
Screenshots/Recordings
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-31.at.09.42.21.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-31.at.09.44.24.mp4
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist