fix: Updated ButtonIcon disabled state

[brianacnguyen]

Development & PR Process

1. Follow MetaMask Mobile Coding Standards
2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
3. Add needs-dev-review label when work is completed
4. Add needs-qa label when dev review is completed
5. Add QA Passed label when QA has signed off

Description

• Update ButtonIcon's disabled state
• Also update ButtonIcon to probably disable

Screenshots/Recordings

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-30.at.09.33.50.mp4

Checklist

• There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[georgewrmarshall]

Can this be closed in favor of #6727?

[brianacnguyen]

They were originally but I split them out to help get things in faster

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

78.9% Coverage
0.0% Duplication

The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

[codecov-commenter]

Codecov Report

Merging #6892 (0c4f8ce) into main (5dd296c) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #6892   +/-   ##
=======================================
  Coverage   32.82%   32.83%           
=======================================
  Files         998      998           
  Lines       26671    26674    +3     
  Branches     2091     2092    +1     
=======================================
+ Hits         8755     8758    +3     
  Misses      17498    17498           
  Partials      418      418           

Files Changed	Coverage Δ
...mponents/Buttons/ButtonIcon/ButtonIcon.stories.tsx	0.00% <0.00%> (ø)
...components/Buttons/ButtonIcon/ButtonIcon.styles.ts	66.66% <60.00%> (-33.34%)	⬇️
...brary/components/Buttons/ButtonIcon/ButtonIcon.tsx	75.00% <83.33%> (+9.78%)	⬆️

[tommasini]

Hey @brianacnguyen, left a question!

If possible could you do as well a recording of button icons working on the app, and a small description of the change? <3

[brianacnguyen]

Hey @brianacnguyen, left a question!

If possible could you do as well a recording of button icons working on the app, and a small description of the change? <3

will add this soon

[tommasini]

LGTM!