feat: update README XCode and python instructions #7107
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7107 +/- ##
=======================================
Coverage 32.86% 32.86%
=======================================
Files 1001 1001
Lines 26743 26743
Branches 2101 2101
=======================================
Hits 8788 8788
Misses 17535 17535
Partials 420 420 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
metamaskbot
added
the
release-7.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a contribution from @heyacherry
At the time #6750 was created, the SonarCloud check needed to pass for all PRs, including external developer PRs.
#7086 was merged yesterday to disable this check for external developers as external developers do not have access to SONAR_TOKEN. However, because #6750 was created before #7086, it was still running the SonarCloud check.
We needed to create a new PR (this PR) to pass or bypass the check.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
fixes #???
Checklist