Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ext contributor SonarCloud #7086

Merged
merged 3 commits into from
Aug 31, 2023
Merged

fix: ext contributor SonarCloud #7086

merged 3 commits into from
Aug 31, 2023

Conversation

sethkfman
Copy link
Contributor

Description

This PR checks to see if sonar cloud can be run and skips it if the user is an external contributor and does not have access to the SONAR_TOKEN.

Screenshots/Recordings

NA

Issue

fixes NA

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@sethkfman sethkfman requested a review from a team as a code owner August 30, 2023 20:10
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

georgewrmarshall
georgewrmarshall reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Is there a way I can manually test this? I suppose I could create a PR with the same code snippet to see if it passes.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023 •
edited

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a1a46a) 32.78% compared to head (90d3cee) 32.78%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7086   +/-   ##
=======================================
  Coverage   32.78%   32.78%           
=======================================
  Files        1001     1001           
  Lines       26710    26710           
  Branches     2096     2096           
=======================================
  Hits         8758     8758           
  Misses      17534    17534           
  Partials      418      418

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sethkfman sethkfman added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 30, 2023
@georgewrmarshall georgewrmarshall mentioned this pull request Aug 30, 2023
Closed
3 tasks
This was referenced Aug 31, 2023
Closed
Closed
georgewrmarshall
georgewrmarshall approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! SonarCloud test is passing on ext contributor test PR with same update #7086

Screenshot 2023-08-31 at 1 28 07 PM

@sethkfman
Copy link
Contributor Author

#7094 Evidence of success with a fork

@sethkfman sethkfman changed the title fix: ext contributor sonar cloud fix: ext contributor SonarCloud Aug 31, 2023
@sethkfman sethkfman added devtools DO-NOT-MERGE Pull requests that should not be merged and removed devtools DO-NOT-MERGE Pull requests that should not be merged labels Aug 31, 2023
@sethkfman sethkfman merged commit 8f088f1 into main Aug 31, 2023
26 of 32 checks passed
@sethkfman sethkfman deleted the fix/ext-contributor-sonar-cloud branch August 31, 2023 22:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 31, 2023
@sethkfman sethkfman added release-7.7.0 Issue or pull request that will be included in release 7.7.0 No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-mobile-client and removed team-mobile-platform labels Aug 31, 2023
@legobeat
Copy link
Contributor

legobeat commented Sep 7, 2023

@sethkfman These two seem to be hanging unmergeable indefinitely waiting on Sonar Cloud:

Some branch protection setting on the GitHub repo that needs a tweak?

@gauthierpetetin gauthierpetetin added team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead labels Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@digiwand digiwand digiwand approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.7.0 Issue or pull request that will be included in release 7.7.0 team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sethkfman @codecov-commenter @legobeat @georgewrmarshall @digiwand @gauthierpetetin