refactor: Migrate store to TypeScript #7110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
migrate-store-to-typescript
branch
2 times, most recently
from
a12d254
to
7d3a46d
Compare
Gudahtt
force-pushed
the
migrate-store-to-typescript
branch
from
7d3a46d
to
481dce1
Compare
Gudahtt
added
needs-dev-review
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7110 +/- ##
==========================================
- Coverage 32.86% 32.85% -0.01%
==========================================
Files 1001 1001
Lines 26757 26756 -1
Branches 2109 2113 +4
==========================================
- Hits 8794 8792 -2
Misses 17540 17540
- Partials 423 424 +1
☔ View full report in Codecov by Sentry. |
Cal-L
added
No QA Needed/E2E Only
The Redux store module and the root reducer have been migrated to TypeScript. We now have the start of a root state object for the Redux state. Most of the reducers still aren't typed, or there are type errors, but it's a start. The missing pieces are typed as `any` for now. The TypeScript conversion introduced some lint errors caused by the pattern of using destructuring to omit object properties. The rule has been updated to allow this pattern (it's already allowed on the latest shared ESLint config). The store type changes required updates to the selectors as well. The types they had been using only included a subset of the root state. They have been updated to use the real root state type instead. This relates to MetaMask/mobile-planning#1226
Gudahtt
force-pushed
the
migrate-store-to-typescript
branch
from
481dce1
to
300ca07
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
metamaskbot
added
the
release-7.8.0
wachunei
reviewed
Sep 5, 2023
| // Source: https://redux.js.org/tutorials/typescript-quick-start | ||
| // Infer the `RootState` and `AppDispatch` types from the store itself | ||
| // @ts-expect-error Type errors in store | ||
| export type RootState = ReturnType<typeof store.getState>; |
There was a problem hiding this comment.
This broke this import:
Fix is to change
import { RootState } from '../../../../reducers/fiatOrders/types';to
import { RootState } from '../../../../reducers';
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
The Redux store module and the root reducer have been migrated to TypeScript. We now have the start of a root state object for the Redux state. Most of the reducers still aren't typed, or there are type errors, but it's a start. The missing pieces are typed as
anyfor now.The TypeScript conversion introduced some lint errors caused by the pattern of using destructuring to omit object properties. The rule has been updated to allow this pattern (it's already allowed on the latest shared ESLint config).
The store type changes required updates to the selectors as well. The types they had been using only included a subset of the root state. They have been updated to use the real root state type instead.
Issue
This relates to https://github.com/MetaMask/mobile-planning/issues/1226
Checklist