fix: Fix type errors in reducers #7147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
fix-reducer-type-errors
branch
from
bba6da3
to
e0179d4
Compare
Gudahtt
commented
Sep 6, 2023
Gudahtt
commented
Sep 6, 2023
Gudahtt
added
needs-dev-review
3 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7147 +/- ##
==========================================
- Coverage 32.75% 32.34% -0.41%
==========================================
Files 1006 1006
Lines 26957 26957
Branches 2128 2128
==========================================
- Hits 8829 8719 -110
- Misses 17701 17809 +108
- Partials 427 429 +2
☔ View full report in Codecov by Sentry. |
Gudahtt
force-pushed
the
fix-reducer-type-errors
branch
4 times, most recently
from
3141bea
to
9ff03aa
Compare
All type errors in the reducers have been fixed. An error in the EngineState type was exposed during this process as well, and has also been fixed (the `PermissionControllerState` was resolving to `never` because the wrong type parameter was passed in). The `fiatOrders` unit tests used selectors quite a lot, so there was a need for a mock/initial root state shape. This was introduced in the `app/util/test` directory for use in unit tests. This initial state object represents just the minimal initial state that has been typed so far. After we migrate all reducers to TypeScript and fix their types, this state object will become increasingly complete/correct. This is a follow-up to #7110, which laid the groundwork for these type fixes but also introduced some of them accidentally.
Gudahtt
force-pushed
the
fix-reducer-type-errors
branch
from
9ff03aa
to
873980a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Gudahtt
added
the
No QA Needed/E2E Only
|
Passing E2E smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5617a7ae-2bc8-4bb7-aac6-c80a31aa66a9 |
Gudahtt
removed
the
needs-dev-review
metamaskbot
added
the
release-7.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
All type errors in the reducers have been fixed. An error in the EngineState type was exposed during this process as well, and has also been fixed (the
PermissionControllerStatewas resolving toneverbecause the wrong type parameter was passed in).The
fiatOrdersunit tests used selectors quite a lot, so there was a need for a mock/initial root state shape. This was introduced in theapp/util/testdirectory for use in unit tests. This initial state object represents just the minimal initial state that has been typed so far. After we migrate all reducers to TypeScript and fix their types, this state object will become increasingly complete/correct.Issue
This is a follow-up to #7110, which laid the groundwork for these type fixes but also introduced some of them accidentally.
Checklist