-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable zkSync Era in Swaps #7256
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7256 +/- ##
=======================================
Coverage 34.61% 34.61%
=======================================
Files 1019 1019
Lines 27193 27193
Branches 2218 2218
=======================================
Hits 9413 9413
Misses 17289 17289
Partials 491 491
☔ View full report in Codecov by Sentry. |
@nikoferro do we need to bump the swaps-controller version to 6.9.2 here? |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explanation
This PR enables zkSync Era in Swaps.
Inspiration taken from this PR that enabled Avalanche: https://github.com/MetaMask/metamask-mobile/pull/3766/files
TODO:
Manual Testing Steps
node_modules/@metamask/swaps-controller/dist/constants.js
use this:exports.DEV_BASE_URL = 'https://swap.dev-api.cx.metamask.io';
node_modules/@metamask/swaps-controller/dist/swapsUtil.js
change thegetBaseApiURL
like this: