Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable Linea for swaps #7352

Merged
merged 5 commits into from
Oct 20, 2023
Merged

feat: enable Linea for swaps #7352

merged 5 commits into from
Oct 20, 2023

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Sep 28, 2023 •
edited by dan437

Description

This PR enables Linea in Swaps.

Inspiration taken from this PR that enabled zkSync: #7256

TODO

  • Bump version of swaps-controller when updated
  • Update swap-api to include Linea feature flags, and also linea /topAssets

Manual testing steps

1. Step1:
2. Step2:
3. ...

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

[screenshot]

After

[screenshot]

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023 •
edited

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@forest-diggs-consensys
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@nikoferro nikoferro changed the title Enable Linea feat: enable Linea for swaps Oct 11, 2023
@nikoferro nikoferro added swaps MetaSwaps issues team-swaps and removed swaps MetaSwaps issues labels Oct 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5c2b9a) 34.56% compared to head (b679b66) 34.56%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7352   +/-   ##
=======================================
  Coverage   34.56%   34.56%           
=======================================
  Files        1020     1020           
  Lines       27291    27291           
  Branches     2233     2233           
=======================================
  Hits         9434     9434           
  Misses      17365    17365           
  Partials      492      492
Files Coverage Δ
app/components/UI/Swaps/utils/index.js 16.12% <ø> (ø)
app/core/Engine.ts 53.94% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan437 dan437 marked this pull request as ready for review October 20, 2023 11:18
@dan437 dan437 requested a review from a team as a code owner October 20, 2023 11:18
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tommasini
tommasini approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tommasini
tommasini approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dan437 dan437 merged commit c31c17d into main Oct 20, 2023
25 checks passed
@dan437 dan437 deleted the linea branch October 20, 2023 17:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 20, 2023
@davibroc davibroc added the QA Passed A successful QA run through has been done label Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-swaps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@infiniteflower @forest-diggs-consensys @codecov-commenter @tommasini @davibroc @nikoferro @metamaskbot @dan437