-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Convert Button stories to csf format #7391
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7391 +/- ##
==========================================
+ Coverage 35.11% 35.16% +0.04%
==========================================
Files 1040 1039 -1
Lines 27654 27622 -32
Branches 2342 2340 -2
==========================================
+ Hits 9711 9712 +1
+ Misses 17418 17385 -33
Partials 525 525 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Left some comments
...component-library/components/Buttons/Button/variants/ButtonPrimary/ButtonPrimary.stories.tsx
Show resolved
Hide resolved
app/component-library/components/Buttons/Button/foundation/ButtonBase/ButtonBase.stories.tsx
Outdated
Show resolved
Hide resolved
app/component-library/components/Buttons/ButtonIcon/ButtonIcon.stories.tsx
Show resolved
Hide resolved
…to morph/convert-buttons
…to morph/convert-buttons
Kudos, SonarCloud Quality Gate passed! |
Description
ButtonLink
,ButtonPrimary
,ButtonSecondary
, andButtonIcon
ButtonBase
ButtonIcon
ButtonIcon
Screenshots/Recordings
Related issues
Fixes #???
Pre-merge author checklist
Pre-merge reviewer checklist