Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Convert ModalConfirmation stories to csf format #7415

Merged
merged 3 commits into from
Nov 17, 2023
Merged

refactor: Convert ModalConfirmation stories to csf format #7415

merged 3 commits into from
Nov 17, 2023

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Oct 8, 2023 •
edited

Description

  • Updated ModalConfirmation story
  • Updated ModalMandatory story
  • Added ModalConfirmation sample const
  • Added ModalMandatory sample const

Screenshots/Recordings

Simulator Screen Shot - iPhone 14 Pro - 2023-10-07 at 18 10 04
Simulator Screen Shot - iPhone 14 Pro - 2023-10-07 at 18 10 18
Simulator Screen Shot - iPhone 14 Pro - 2023-10-07 at 18 27 11
Simulator Screen Shot - iPhone 14 Pro - 2023-10-07 at 18 27 14

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Oct 8, 2023
@brianacnguyen brianacnguyen self-assigned this Oct 8, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner October 8, 2023 01:30
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (24b4b7e) 34.61% compared to head (2f9fc87) 34.63%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7415      +/-   ##
==========================================
+ Coverage   34.61%   34.63%   +0.01%     
==========================================
  Files        1017     1017              
  Lines       27162    27161       -1     
  Branches     2211     2211              
==========================================
+ Hits         9402     9406       +4     
+ Misses      17273    17268       -5     
  Partials      487      487
Files Coverage Δ
...s/ModalConfirmation/ModalConfirmation.constants.ts 66.66% <50.00%> (-33.34%) ⬇️
.../Modals/ModalMandatory/ModalMandatory.constants.ts 66.66% <50.00%> (-33.34%) ⬇️
...ls/ModalConfirmation/ModalConfirmation.stories.tsx 0.00% <0.00%> (ø)
...s/Modals/ModalMandatory/ModalMandatory.stories.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

28.6% 28.6% Coverage
0.0% 0.0% Duplication

georgewrmarshall
georgewrmarshall reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between this PR and this PR #7391

@brianacnguyen brianacnguyen changed the title refactor: Convert Button stories to csf format refactor: Convert ModalConfirmation stories to csf format Oct 25, 2023
@brianacnguyen
Copy link
Contributor Author

What's the difference between this PR and this PR #7391

Updated name

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

28.6% 28.6% Coverage
0.0% 0.0% Duplication

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 17, 2023
georgewrmarshall
georgewrmarshall approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • checked stories and controls ✅

@georgewrmarshall georgewrmarshall merged commit 233d123 into main Nov 17, 2023
52 checks passed
@georgewrmarshall georgewrmarshall deleted the morph/convert-modals branch November 17, 2023 01:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 17, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.12.0 Issue or pull request that will be included in release 7.12.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brianacnguyen @codecov-commenter @georgewrmarshall @metamaskbot